[YouTube] Fix partial non-extraction of "No views" string in stream items #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
bug
AudricV
force-pushed
the
yt_fix-no-views-extraction-playlist-items
branch
from
ac9bb92 to
7bfddf7
Compare
Stypox
reviewed
Feb 26, 2023
...org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java
Outdated
Show resolved
Hide resolved
As the "No views" string is returned in the case there is no view on a video, a number cannot be parsed in this case, so -1 was returned. This string is now detected in all methods to get the view count of a stream.
This refactoring avoids code duplication as much as possible.
AudricV
force-pushed
the
yt_fix-no-views-extraction-playlist-items
branch
from
7bfddf7 to
bd79b92
Compare
Stypox
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the "No views" string is returned in the case there is no view on a YouTube video, a number cannot be parsed in this case, so -1 was returned, as the detection of this string was only made for the first value (
viewCountText).This string is now detected in all methods to get the view count of a stream item and the corresponding code has been refactored to reduce code duplication as much as possible.