[YouTube] Fix channel ID extraction of YouTube channels RSS feeds #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudricV
added
bug
Stypox
approved these changes
Jan 19, 2023
...main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeFeedExtractor.java
Outdated
Show resolved
Hide resolved
...main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeFeedExtractor.java
Show resolved
Hide resolved
The yt:channelId element doesn't provide the channel ID anymore and is empty, like the id element, so we need now to extract it from the channel URL provided in two elements: author -> uri and feed -> link. Also avoid a NullPointerException in getUrl and getName methods.
AudricV
force-pushed
the
yt_fix-channel-id-rss-feeds
branch
from
7f2b4c8 to
1f4ed9d
Compare
Stypox
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RSS channels feeds, the
yt:channelIdelement doesn't provide the channel ID anymore (it has no value), like theidelement (only theyt:channel:prefix is provided). This currently makesgetId()method ofYoutubeFeedExtractorreturningnull, and so fails the methodtestIdofYoutubeFeedExtractorTest.Kurzgesagttest class.We need now to extract it from the channel URL provided in two elements:
author->uriandfeed->link.This PR also avoids
NullPointerExceptions which could happen ingetUrlandgetNamemethods ofYoutubeFeedExtractor.