Make 'Stream' classes implement Serializable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right breaking the java support is a no go. |
|
Will you merge this? |
|
Yes |
raveeolee
referenced
this pull request
Mar 31, 2018
…on info. -Moved subtitles to optional data extraction.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to implement
Serializablein order to be able to pass Objects (lists, streams) between activitys, services through Intents (putExtra) .I've been implementing the quality selector, so it's necessary.
PS: I was thinking in implement the
Parcelable(faster) , but that would break the command-line, as this class only exist in Android