Skip to content

Commit

Permalink
Merge pull request #1236 from Thompson3142/fix_scrubbing_seekbar_prev…
Browse files Browse the repository at this point in the history
…iew_crash

Add documentation for faulty framesets
  • Loading branch information
TobiGr authored Oct 27, 2024
2 parents 6af22e3 + 1f26c12 commit c343e31
Showing 1 changed file with 14 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1377,6 +1377,20 @@ private ItagInfo buildAndAddItagInfoToList(
return itagInfo;
}


/**
* {@inheritDoc}
* Should return a list of Frameset object that contains preview of stream frames
*
* <p><b>Warning:</b> When using this method be aware
* that the YouTube API very rarely returns framesets,
* that are slightly too small e.g. framesPerPageX = 5, frameWidth = 160, but the url contains
* a storyboard that is only 795 pixels wide (5*160 > 795). You will need to handle this
* "manually" to avoid errors.</p>
*
* @see <a href="https://github.com/TeamNewPipe/NewPipe/pull/11596">
* TeamNewPipe/NewPipe#11596</a>
*/
@Nonnull
@Override
public List<Frameset> getFrames() throws ExtractionException {
Expand Down

0 comments on commit c343e31

Please sign in to comment.