Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README.asm.md #9618

Closed
wants to merge 12 commits into from
Closed

Create README.asm.md #9618

wants to merge 12 commits into from

Conversation

WirelessAlien
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Relies on the following changes

  • Adds Readme in Assamese Language
    Assamese have language codes "asm"

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@WirelessAlien
Copy link
Contributor Author

WirelessAlien commented Jan 3, 2023

I have seen this comment -
i will close this one, will start fresh in new PR tomorrow. sorry for the mess up @ShareASmile. That's why I started a new in the doc folder and I will not create another for main README file, you can edit that for both languages.

I copied the description for PR from you @ShareASmile 😉
Sorry if I did any mistake.

@ShareASmile
Copy link
Collaborator

@WirelessAlien , you should add the link to Assamese READMe inside the others READMEs & also in english one.

<!-- Hey there. Thank you so much for improving NewPipe, and filling out the details. Having roughly the same layout helps everyone considerably :)-->

#### What is it?
- [ ] Bugfix (user facing)
- [ ] Feature (user facing)
- [ ] Codebase improvement (dev facing)
- [x] Meta improvement to the project (dev facing)


#### Relies on the following changes

- Adds Readme link of Assamese Language 
 to primary README.md

#### APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

#### Due diligence
- [x] I read the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md).
@WirelessAlien
Copy link
Contributor Author

@WirelessAlien , you should add the link to Assamese READMe inside the others READMEs & also in english one.

Done.

@TobiGr TobiGr added the localisation / translation Everything that has to do with translations or Weblate label Jan 15, 2023
TobiGr added a commit that referenced this pull request Jul 17, 2023
Taken from #9618 with updated screenshots

Co-authored-by:  Abhilash <121420261+WirelessAlien@users.noreply.github.com>
TobiGr added a commit that referenced this pull request Jul 17, 2023
Taken from #9618 with updated screenshots

Co-authored-by:  Abhilash <121420261+WirelessAlien@users.noreply.github.com>
TobiGr added a commit that referenced this pull request Jul 17, 2023
Taken from #9618 with updated screenshots

Co-authored-by:  Abhilash <121420261+WirelessAlien@users.noreply.github.com>
@TobiGr TobiGr mentioned this pull request Jul 17, 2023
5 tasks
@TobiGr
Copy link
Contributor

TobiGr commented Jul 17, 2023

Thank you for your work. Your changes were merged in #10240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants