-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RxJava to 3.1.5. #9520
Update RxJava to 3.1.5. #9520
Conversation
With that big a bump, I hope it magically fixes some bugs. |
The newer version does fix some bugs (though I'm not sure if they apply in NewPipe.) It does make use of functionality only available on API 21+, which should reduce power consumption: ReactiveX/RxJava#7293 |
Shouldn't you update RxAndroid to 3.0.2 as well (maybe in a separate PR)? |
Sure, but the changes aren't very major, and it seems active development is not happening, as it's pretty stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and it seems to work well. I tested on API 33 and API 22. Thanks!
Kudos, SonarCloud Quality Gate passed! |
What is it?
Description of the changes in your PR
This should reduce power consumption on mobile devices: Removes the purge thread in favour of standard ScheduledThreadPoolExecutor APIs ReactiveX/RxJava#7293
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence