Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle checksum #7442

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Fix Gradle checksum #7442

merged 1 commit into from
Nov 26, 2021

Conversation

triallax
Copy link
Contributor

What is it?

  • Codebase improvement(?) (dev facing)

Description of the changes in your PR

Use the correct SHA-256 checksum for the Gradle distribution. @Redirion added it in a recent PR (#7418), but the checksum was the wrong one, something that I noticed while building locally (yeah, this did have me quite worried). Somehow the CI ran without any issues.

Due diligence

Please don't merge if you don't check this locally.

Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Redirion Redirion merged commit ef91214 into TeamNewPipe:dev Nov 26, 2021
@XiangRongLin
Copy link
Collaborator

And i was thinking that something went wrong on the side of gradle when my nightly builds were failing. XiangRongLin/NewPipe-nightly#6
Thanks for the fix

@Redirion
Copy link
Member

I am sorry for that

@triallax
Copy link
Contributor Author

@Redirion we all make mistakes. :)

This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants