Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Check for updates" button in update settings #7296

Merged
merged 6 commits into from
Nov 1, 2021

Conversation

vhouriet
Copy link
Contributor

@vhouriet vhouriet commented Oct 22, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

I added a "Check for updates" button in the update settings that opens the "Releases" page of this github repo.

Before/After Screenshots/Screen Record

  • Before:

  • After:
screen-20211022-211945.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex
Copy link
Member

litetex commented Oct 23, 2021

Thank you for the PR!

I added a "Check for updates" button in the update settings that opens the "Releases" page of this github repo.

However #6049 states that the "Check for update"-button should trigger a update check and not open the GH releases site.

In my opinion we now have 2 options:

  • Make the check for update-button do a update check
  • Rename the button to something like "Show releases" - however

@vhouriet vhouriet closed this Oct 23, 2021
@vhouriet
Copy link
Contributor Author

@litetex I got the check for updates button to do a correct check update. But I have a question, is it okay to have no way to test it in a debug build as I have it now ? I tested it on my side, but with a quick and ugly fix.

@vhouriet vhouriet reopened this Oct 23, 2021
@litetex
Copy link
Member

litetex commented Oct 24, 2021

@vhouriet
I think the reviewer (currently none) has to determine if this is okay or not.

When I review this issue (hopefully in the next time) then I will come back to this 😄

PS: Shrunk the image in the issue description a bit (less scrolling 😉)

@litetex litetex self-requested a review October 26, 2021 17:25
@litetex litetex force-pushed the vhouriet_feature_issue6049 branch from 504c011 to 403154b Compare October 26, 2021 18:47
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seems to work as expected when isReleaseApk is set to true.

I also did some minor fixes regarding

  • dead code
  • naming (GithubAPKReleaseAPK)
  • code format

and rebased the branch so it's up-to-date.

@litetex litetex merged commit c0f7b12 into TeamNewPipe:dev Nov 1, 2021
This was referenced Nov 30, 2021
@vhouriet vhouriet deleted the vhouriet_feature_issue6049 branch December 22, 2021 11:37
@vhouriet vhouriet restored the vhouriet_feature_issue6049 branch December 22, 2021 11:37
@vhouriet vhouriet deleted the vhouriet_feature_issue6049 branch December 22, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual update check button in the Updates page of the app
2 participants