-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Check for updates" button in update settings #7296
Conversation
Thank you for the PR!
However #6049 states that the "Check for update"-button should trigger a update check and not open the GH releases site. In my opinion we now have 2 options:
|
@litetex I got the check for updates button to do a correct check update. But I have a question, is it okay to have no way to test it in a debug build as I have it now ? I tested it on my side, but with a quick and ugly fix. |
@vhouriet When I review this issue (hopefully in the next time) then I will come back to this 😄 PS: Shrunk the image in the issue description a bit (less scrolling 😉) |
When we build APKs in PRs it's also a GITHUB_APK...
Also removed a useless variable
504c011
to
403154b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seems to work as expected when isReleaseApk
is set to true
.
I also did some minor fixes regarding
- dead code
- naming (
GithubAPK
→ReleaseAPK
) - code format
and rebased the branch so it's up-to-date.
What is it?
Description of the changes in your PR
I added a "Check for updates" button in the update settings that opens the "Releases" page of this github repo.
Before/After Screenshots/Screen Record
screen-20211022-211945.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence