-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share/Open with newpipe" add enqueue choice for players #7266
Conversation
* Better code structure (methods) * Reformatted code * Improved naming * Refactored UI * Removed useless layouts * Increased clickable advanced options area * Use a layout for possible future advanced options * Reworked margins so that there are no gigantic distances between the components * Instead of adding e.g. the drop-down icon programmatically manage it the same as in video-detail * Animated the drop-down icon * Removed unused icon * Fixed light theme not working with the icon * Added tooltip so users better know what the "Prioritize stream queuing" means (sadly only works for Android 8+)
Should it be a separate toggle? I think it should be the default behaviour. If something is already playing, Newpipe should always enqueue a video link shared to it instead of playing it directly and potentially causing information loss (of an existing video or queue). |
@opusforlife2 |
The user might have arrived at their currently open stream by clicking on links after links, and may not remember the name of the video or the channel. Then there should be a way to avoid the unintentional or accidental data loss (the currently playing video that would be removed). The currently playing video should be shifted to the 2nd position in the queue, or something similar. Or, the newly opened video should open as a new page on the backstack, so that when the user finishes watching it, they can then just tap Actually, this 2nd suggestion could remove a whole class of problems. Just add externally opened links to the backstack too. You will never lose your place in the app. |
Uhm wouldn't that be visible in the "History"?
I think introducing this here would blow up the scope of the PR. Also note that there have been a lot of discussions in #5850. |
Not everyone has history enabled.
Sure, no problem. |
Maybe we need some kind of behavior like suggested for the back button in another PR. Anyway I think there are so many options which can happen when someone wants to open a already playing video, so I think we have to do a major rework sooner or later: e.g.: "Open action" setting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to hide the enqueue option under an "Advanced options" menu? The space needed for the single switch is the same as that needed for the advanced options menu, and the amount of data on the screen is also the same, so I wouldn't do it like this. I'd just have the switch there and call it a day: people who don't know what it is or who don't use it can ignore it without any problem, but people who want to use it save one click.
By the way, I still don't get why we can't just add an "Enqueue" entry when a player is active and use the currently active player. This way the user does not have to remember which player he is currently on each time he wants to enqueue. In the settings this could be modeled in the menu as "Enqueue / play on main player", "Enqueue / play on audio player", "Enqueue / play on popup player".
@@ -0,0 +1,78 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to use a ConstraintLayout
to prevent view nesting?
Co-authored-by: Stypox <stypox@pm.me>
Co-authored-by: Stypox <stypox@pm.me>
#7266 (review) This issue has to go back to the drawing board... |
This comment has been minimized.
This comment has been minimized.
Is there a version with this option / enqueue available? This is great and much needed. |
@offshade While logged in, go to the Checks tab of this PR, then click on Artifacts. You can download the zipped APK from it. It will install a debug version of Newpipe which won't interfere with the main version. You can delete it after the main version gets this feature and resume using that. |
This is so awesome! Thank you very very much. |
Version doesn't work anymore. |
@offshade Wait for the PR to be rebased. |
I will wait for anything, although being clueless about technical stuff, I have no idea what you just said... 😂 Hope any update will be posted here. |
This comment was marked as duplicate.
This comment was marked as duplicate.
In the current state not.
Read the above comments.
No. |
The enqueue option could be the non-default dialog option if you are concerned about background versus foreground player antics. This would force the user to make an informed decision to set always open this way. This has been broken since version 18 or something when background player lost the ability to enqueue separately. Also, addressing the history comment as a work around, it isn't a work around because I'll often enqueue multiple videos and they won't be marked in my history unless they play. |
This comment was marked as abuse.
This comment was marked as abuse.
I'm confused with the status of this PR. Isn't this already worked upon? |
Yes, but there is currently no agreement on how the UI should look and behave |
Any updates in this issue? This version doesn't work anymore. Anything with enqueue option available? |
any chance for this to be reviewed.? |
This PR is quite outdated in its current state. If someone wants to resume this, it can be reopened. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I would really appreciate this getting fixed and it broke the way I used NewPipe. |
What is it?
Description of the changes in your PR
Successor to #5850 (please take a look at that PR for the basic description).
This is a new PR because it's not possible for a maintainer to modify the old one and I otherwise had to request so many tiny changes which would not be easily doable.
TL;DR - changes on top:
Before/After Screenshots/Screen Record
NPEnqueOptionDemo.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence