Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RecyclerView & Groupie libraries #7261

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update RecyclerView 1.1.0 -> 1.2.1 (changelog)
  • Update Groupie 2.9.0 -> 2.10.0 (changelog)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

I got the Groupie maintainers to update their RecyclerView version to 1.2.x so this could be done :)

I tested an APK on my Android 10 device, everything seems to behave the same way.

@TacoTheDank TacoTheDank changed the title Update RecyclerView & Groupie Update RecyclerView & Groupie libraries Oct 16, 2021
@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Oct 16, 2021
@litetex litetex self-requested a review October 17, 2021 12:30
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Seems to work as expected.

However some minor things should be clarified.

app/build.gradle Show resolved Hide resolved
@litetex litetex merged commit 7067deb into TeamNewPipe:dev Oct 24, 2021
@TacoTheDank TacoTheDank deleted the bumpRecyclerView branch October 24, 2021 19:26
This was referenced Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants