Add debug option to disable media tunneling #6288
Conversation
| @@ -172,6 +172,7 @@ | |||
| <string name="show_memory_leaks_key" translatable="false">show_memory_leaks_key</string> | |||
| <string name="allow_disposed_exceptions_key" translatable="false">allow_disposed_exceptions_key</string> | |||
| <string name="show_original_time_ago_key" translatable="false">show_original_time_ago_text_key</string> | |||
| <string name="disable_media_tunneling_key" translatable="false">disable_media_tunneling_text_key</string> | |||
There was a problem hiding this comment.
What's the reason for using a different value here?
| <string name="disable_media_tunneling_key" translatable="false">disable_media_tunneling_text_key</string> | |
| <string name="disable_media_tunneling_key" translatable="false">disable_media_tunneling_key</string> |
There was a problem hiding this comment.
was asking that myself. I was just copying from <string name="show_original_time_ago_key" translatable="false">show_original_time_ago_text_key</string>
There was a problem hiding this comment.
I have removed it from both
There was a problem hiding this comment.
if you change the key value, we might want to add a SettingsMigration. I am not sure if this a bit too much effort for a rarely used debug setting.
There was a problem hiding this comment.
yes, I would say that a migration is not required. But out of curiosity, is there a concept for it in Android and/or do we already have a settings migration in NewPipe?
There was a problem hiding this comment.
We already have one: SettingsMigrations.java
TobiGr
added
the
player
What is it?
Description of the changes in your PR
Added an option for DEBUG builds only to help users to check if their issues with video (blackscreen or stuttering) are a cause of not working media tunneling on their device / custom os.
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence