Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed player not automatically playing #6266

Merged
merged 2 commits into from
May 12, 2021
Merged

Fixed player not automatically playing #6266

merged 2 commits into from
May 12, 2021

Conversation

litetex
Copy link
Member

@litetex litetex commented May 11, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes the following issue(s)

Relies on the following changes

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@litetex
Copy link
Member Author

litetex commented May 11, 2021

Testresults (locally):
Before fix:

TheBug.mp4

After fix (with "History and cache>Resume playback" set to off):

Fixed.mp4

Redirion
Redirion approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. This is a "5-star" PR. Even with videos to show that everything works as expected!

@Redirion Redirion merged commit 31ea44c into TeamNewPipe:dev May 12, 2021
@TobiGr TobiGr added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels May 12, 2021
@litetex litetex deleted the fix-paused-videos branch May 13, 2021 18:53
@SameenAhnaf SameenAhnaf mentioned this pull request May 18, 2021
Closed
4 tasks
This was referenced May 23, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Redirion Redirion Redirion approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Videos begin in the paused state
3 participants
@litetex @Redirion @TobiGr