-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some warnings #6189
Fix some warnings #6189
Conversation
app/src/main/java/org/schabi/newpipe/local/subscription/dialog/FeedGroupDialog.kt
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/local/subscription/SubscriptionFragment.kt
Outdated
Show resolved
Hide resolved
Also, can you fix this?
It seems that some translations of these two removed strings haven't been removed. |
Thanks for the pointer; I had wanted to fix those warnings, but I didn't really know what they meant. I'll fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, now we need someone who can test the changes on a KitKat device.
@mhmdanas Could you be more specific? What workflow(s) should work and what should we look out for? |
@mqus sorry, I'm not too sure what the code does, so I can't be much more specific, but I'll try. Basically, I just changed the way a color is being loaded, so all you have to do open the subscriptions tab, press the "new" button in the "channel groups" section, and then press "Select subscriptions"; after that just please check that the colors are correct (e.g. press the search button), preferably in multiple themes. |
Thank you, this really helped! I just notice that the UI reloads after changing a theme(normal) and reloads again when I've closed the settings(seems unnecessary), even though the scheme was already applied. But this only occurred sometimes, I can't reproduce it right now. The colors are fine 👍 |
@TiA4f8R now that this was confirmed to work fine on KitKat, can you please go ahead and merge this? |
What is it?
Description of the changes in your PR
Fix a number of warnings.
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence