Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings #6189

Merged
merged 3 commits into from
May 4, 2021
Merged

Fix some warnings #6189

merged 3 commits into from
May 4, 2021

Conversation

triallax
Copy link
Contributor

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

Fix a number of warnings.

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@triallax triallax added the codequality Improvements to the codebase to improve the code quality label Apr 27, 2021
@AudricV
Copy link
Member

AudricV commented Apr 28, 2021

Also, can you fix this?

> Task :app:javaPreCompileDebug
warn: removing resource org.schabi.newpipe.debug.fixsomewarnings:string/popup_resizing_indicator_title without required default value.
warn: removing resource org.schabi.newpipe.debug.fixsomewarnings:string/related_streams_tab_description without required default value.

It seems that some translations of these two removed strings haven't been removed.

@triallax
Copy link
Contributor Author

triallax commented Apr 28, 2021

Thanks for the pointer; I had wanted to fix those warnings, but I didn't really know what they meant. I'll fix them.

Copy link
Member

@AudricV AudricV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, now we need someone who can test the changes on a KitKat device.

@triallax
Copy link
Contributor Author

triallax commented May 1, 2021

@mqus @MD77MD mind testing the feed group dialog on KitKat? Preferably with multiple themes.

@mqus
Copy link
Contributor

mqus commented May 2, 2021

@mhmdanas Could you be more specific? What workflow(s) should work and what should we look out for?

@triallax
Copy link
Contributor Author

triallax commented May 2, 2021

@mqus sorry, I'm not too sure what the code does, so I can't be much more specific, but I'll try.

Basically, I just changed the way a color is being loaded, so all you have to do open the subscriptions tab, press the "new" button in the "channel groups" section, and then press "Select subscriptions"; after that just please check that the colors are correct (e.g. press the search button), preferably in multiple themes.

@mqus
Copy link
Contributor

mqus commented May 3, 2021

Thank you, this really helped!

I just notice that the UI reloads after changing a theme(normal) and reloads again when I've closed the settings(seems unnecessary), even though the scheme was already applied. But this only occurred sometimes, I can't reproduce it right now. The colors are fine 👍

@triallax
Copy link
Contributor Author

triallax commented May 4, 2021

@TiA4f8R now that this was confirmed to work fine on KitKat, can you please go ahead and merge this?

@TobiGr TobiGr merged commit c7510c6 into TeamNewPipe:dev May 4, 2021
@triallax triallax deleted the fix-some-warnings branch May 9, 2021 17:00
This was referenced May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants