Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Export" to "Import" in Korean Readme instructions #5250

Merged
merged 1 commit into from
Jan 1, 2021

Conversation

opusforlife2
Copy link
Collaborator

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Both the middle and last steps said to "export database". Changed the latter to "import".

Fixes the following issue(s)

  • Possible confusion in Korean users.

Due diligence

@TobiGr
Copy link
Contributor

TobiGr commented Dec 22, 2020

Is there no Korean translation of these strings in the app? Why are the English words used here?

@TobiGr TobiGr added the localisation / translation Everything that has to do with translations or Weblate label Dec 22, 2020
@opusforlife2
Copy link
Collaborator Author

You'll have to ask Kim Min-Tae. ¯\_(ツ)_/¯

@TobiGr
Copy link
Contributor

TobiGr commented Dec 22, 2020

CC @KIMMINTAE98

@opusforlife2
Copy link
Collaborator Author

You could just merge this and change the language later, when a Korean contributor is available.

@TobiGr TobiGr merged commit 16c44f3 into dev Jan 1, 2021
@TobiGr TobiGr deleted the Korean_readme_fix branch January 1, 2021 17:47
This was referenced Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants