Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings for default download media type. #3901

Closed
wants to merge 2 commits into from

Conversation

vmazoyer
Copy link
Contributor

What is it?

  • Feature (user facing)

Description of the changes in your PR

  • Users can now select a default media type for their downloads.

Fixes the following issue(s)

Relies on the following changes

  • Added a new setting in the download preferences.

Agreement

  • I carefully read the contribution guidelines and agree to them. Please note that I do not plan to maintain this feature.

@TobiGr
Copy link
Contributor

TobiGr commented Jul 18, 2020

The better approach is to store the last used download type and auto-select it.

@vmazoyer
Copy link
Contributor Author

How about adding "Last used" as a 4th option?
In my use case I prefer to be able to select a media type rather than "last used".

@opusforlife2
Copy link
Collaborator

How about adding "Last used" as a 4th option?

Best of both worlds.

@vmazoyer vmazoyer force-pushed the persistent_dl_pref branch from 93a2e29 to fa3bad3 Compare July 19, 2020 09:01
@Stypox
Copy link
Member

Stypox commented Jul 21, 2020

Best of both worlds.

Nope, @TobiGr suggested to always use the last configuration in order not to add yet another niche option.

@opusforlife2
Copy link
Collaborator

Nope, @TobiGr suggested to always use the last configuration in order not to add yet another niche option.

Throw it in a new Miscellaneous Settings menu we've discussed earlier, I say!

@TobiGr TobiGr added the downloader Issue is related to the downloader label Jul 22, 2020
@vmazoyer
Copy link
Contributor Author

vmazoyer commented Aug 1, 2020

I made the changes according to the feedback here: no additional setting; just remember the last option used.
To keep things clean I decided to rebase and open a new PR: #4038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Issue is related to the downloader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants