Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feed group main-page tab #3556

Closed
wants to merge 1 commit into from
Closed

Feed group main-page tab #3556

wants to merge 1 commit into from

Conversation

Royosef
Copy link
Contributor

@Royosef Royosef commented May 9, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

feat(group-feed-tab)

  • add group feed as tab in the main page (by Settings > Content > Content of main page)

image

image

image

image

Fixes the following issue(s)

Testing apk

NewPipe_FeedGroupTab-debug.zip

Agreement

@Royosef
feat(group-feed-tab)
c23274c 
* add group feed as tab in the main page (by Settings > Content > Content of main page)
@opusforlife2
Copy link
Collaborator

Hallelujah!

@opusforlife2
Copy link
Collaborator

Suggestion: Add a button to "Add tab to Main Page" in the Feed creation dialogue. So that you can create the feed and add it as a tab right away. It would be handy to have, even though it would appear at the end of the list of tabs. One could always change positions later.

@opusforlife2
Copy link
Collaborator

Swiping between these Feed tabs is very jerky. Not sure if that's a bug or just a consequence of heavy loading.

Create 2 or 3 tabs and swipe through them all. Better yet, group all the feed tabs together. The behavior is very noticeable.

@B0pol B0pol mentioned this pull request May 9, 2020
Closed
@B0pol B0pol linked an issue May 9, 2020 that may be closed by this pull request
Feature request: display feed group's subscriptions in tab #3559
Closed
@B0pol B0pol removed a link to an issue May 10, 2020
Feature request: display feed group's subscriptions in tab #3559
Closed
@B0pol B0pol added feature request Issue is related to a feature in the app feed Issue is related to the feed labels May 10, 2020
@opusforlife2 opusforlife2 mentioned this pull request May 27, 2020
Open
@ghost ghost mentioned this pull request Jul 10, 2020
Closed
This was referenced Nov 3, 2020
Open
Closed
@khimaros
Copy link
Contributor

are there any changes required to this PR before it can be merged?

@TobiGr TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24
@Stypox Stypox changed the title feat(group-feed-tab) Feed group main-page tab Mar 18, 2021
@peat80 peat80 mentioned this pull request Apr 20, 2021
Closed
4 tasks
@opusforlife2
Copy link
Collaborator

@Royosef Do you have time to finish this PR?

@Royosef
Copy link
Contributor Author

Royosef commented Jun 3, 2021

Sorry, but I got no time for that 😕

@litetex litetex marked this pull request as draft October 1, 2021 17:18
@litetex
Copy link
Member

litetex commented Oct 1, 2021

Closing this for now:

  • No progress
  • no GitHub actions build
  • merge conflicts

Feel free to reopen it when there is progress again.

@litetex litetex closed this Oct 1, 2021
@litetex litetex mentioned this pull request Oct 10, 2021
Closed
2 tasks
@Coderdude112
Copy link

Any update on this PR?

@peat80 peat80 mentioned this pull request Jun 11, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app feed Issue is related to the feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding custom feeds as tabs
6 participants
@Royosef @opusforlife2 @khimaros @litetex @Coderdude112 @B0pol