Update to ExoPlayer 2.10.5 #2697

Redirion · 2019-10-07T06:02:27Z

I carefully read the contribution guidelines and agree to them.

As we now finally have AndroidX I was able to update ExoPlayer to the latest version.
This brings numerous of needed fixes and improvements to NewPipe. Have a look at the ReleaseNotes: https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md

This might close #2257 and #2373 and possible other issues.

Debug apk for testing: https://github.com/Redirion/NewPipe/releases/download/v0.17.3-exo/app-debug.apk

Notes for Review:

Changes to the MediaSessionManager and PlayQueueNavigator were mainly required due to this commit in ExoPlayer: google/ExoPlayer@063f570
I also had to fiddle again in CustomTrackSelector as there have been changes again. I already tried subtitles (it seems to be working fine this time :D)
I have updated Gradle to 3.4.0 to match ExoPlayer's gradle version
okhttp has been updated as well to match ExoPlayer (thus deemed stable)
With the new isPlaying() method in BasePlayer NewPipe makes already use of a new feature added in ExoPlayer 2.10.5

TobiGr · 2019-10-07T09:13:24Z

I think something went wrong while rebasing / merging. Should I force push the branch to get it right?

Redirion · 2019-10-07T09:15:55Z

why does this always happen..
I saw your extractor update commit, got excited and wanted to to everything right with a rebase. So I did:
git remote add upstream https://github.com/TeamNewPipe/NewPipe.git
git fetch upstream
git rebase dev <- maybe I should have skipped this one?
git pull --rebase upstream dev
git pull
git push -u origin exoplayer2105

I should have just click the update button here (but I was once told, that this is not the preferred way)

Can you fix it? 😞

TobiGr · 2019-10-07T09:16:33Z

~~I tried to open a video~~
Happens when rotating the screen

Exception

User Action: ui error
Request: App crash, UI failure
Content Language: GB
Service: none
Version: 0.17.3
OS: Linux ,release-keys 6.0 - 23

Crash log

java.lang.RuntimeException: Unable to destroy activity {org.schabi.newpipe.debug/org.schabi.newpipe.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void androidx.viewpager.widget.ViewPager.setAdapter(androidx.viewpager.widget.PagerAdapter)' on a null object reference
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3852)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:3870)
	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:4074)
	at android.app.ActivityThread.-wrap15(ActivityThread.java)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1360)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:148)
	at android.app.ActivityThread.main(ActivityThread.java:5443)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void androidx.viewpager.widget.ViewPager.setAdapter(androidx.viewpager.widget.PagerAdapter)' on a null object reference
	at org.schabi.newpipe.fragments.MainFragment.onDestroy(MainFragment.java:115)
	at androidx.fragment.app.Fragment.performDestroy(Fragment.java:2830)
	at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1028)
	at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManagerImpl.java:1238)
	at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1310)
	at androidx.fragment.app.FragmentManagerImpl.dispatchStateChange(FragmentManagerImpl.java:2659)
	at androidx.fragment.app.FragmentManagerImpl.dispatchDestroy(FragmentManagerImpl.java:2644)
	at androidx.fragment.app.FragmentController.dispatchDestroy(FragmentController.java:329)
	at androidx.fragment.app.FragmentActivity.onDestroy(FragmentActivity.java:366)
	at androidx.appcompat.app.AppCompatActivity.onDestroy(AppCompatActivity.java:233)
	at org.schabi.newpipe.MainActivity.onDestroy(MainActivity.java:352)
	at android.app.Activity.performDestroy(Activity.java:6415)
	at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1165)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3839)
	... 10 more
java.lang.NullPointerException: Attempt to invoke virtual method 'void androidx.viewpager.widget.ViewPager.setAdapter(androidx.viewpager.widget.PagerAdapter)' on a null object reference
	at org.schabi.newpipe.fragments.MainFragment.onDestroy(MainFragment.java:115)
	at androidx.fragment.app.Fragment.performDestroy(Fragment.java:2830)
	at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1028)
	at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManagerImpl.java:1238)
	at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1310)
	at androidx.fragment.app.FragmentManagerImpl.dispatchStateChange(FragmentManagerImpl.java:2659)
	at androidx.fragment.app.FragmentManagerImpl.dispatchDestroy(FragmentManagerImpl.java:2644)
	at androidx.fragment.app.FragmentController.dispatchDestroy(FragmentController.java:329)
	at androidx.fragment.app.FragmentActivity.onDestroy(FragmentActivity.java:366)
	at androidx.appcompat.app.AppCompatActivity.onDestroy(AppCompatActivity.java:233)
	at org.schabi.newpipe.MainActivity.onDestroy(MainActivity.java:352)
	at android.app.Activity.performDestroy(Activity.java:6415)
	at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1165)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:3839)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:3870)
	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:4074)
	at android.app.ActivityThread.-wrap15(ActivityThread.java)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1360)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:148)
	at android.app.ActivityThread.main(ActivityThread.java:5443)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

TobiGr · 2019-10-07T09:20:24Z

I think the last git pull is wrong. However, where does the merge commit come from?

Redirion · 2019-10-07T09:22:10Z

from git pull --rebase upstream dev, it automatically created the merge.
I don't see how your crash is related to the ExoPlayer Update (also unable to reproduce)

before I made the last "git pull", "git status" gave this output:
Auf Branch exoplayer2105
Ihr Branch und 'origin/exoplayer2105' sind divergiert,
und haben jeweils 5 und 4 unterschiedliche Commits.
(benutzen Sie "git pull", um Ihren Branch mit dem Remote-Branch zusammenzuführen)

nichts zu committen, Arbeitsverzeichnis unverändert.

edit: Maybe it was that last git pull that created the merge.

TobiGr · 2019-10-07T09:24:49Z

from git pull --rebase upstream dev, it automatically created the merge.

Not for me 🤔

I don't see how your crash is related to the ExoPlayer Updat (also unable to reproduce)

Oh yeah, I cannot reproduce it either... It just happened the first time I tried to open a video.

TobiGr

Just white spaces

app/src/main/java/org/schabi/newpipe/player/mediasession/PlayQueuePlaybackController.java

app/src/main/java/org/schabi/newpipe/player/playback/CustomTrackSelector.java

Co-Authored-By: Tobias Groza <TobiGr@users.noreply.github.com>

TobiGr · 2019-10-07T09:34:17Z

I'll do some further testing on most supported Android versions during the day to make sure nothing broke. NewPipe without a working player is quite useless. When testing succeeds, I'll merge and start preparations for a new release.

Redirion · 2019-10-07T09:37:33Z

Samsung Galaxy S7 with Android 8.0.0 looking good so far

Stypox · 2019-10-07T11:00:59Z

Changing resolution and then changing it again before the video has finished loading causes the playback time to reset to 0:00. This bug is not present in the latest app release.

Apart from this everything looks good on Android 7

Pentaphon · 2019-10-07T13:06:29Z

Increase maximum video buffer size from 13MB to 32MB. The previous default was too small for high quality streams.

Yes! We needed this for Newpipe videos for sure.

Redirion · 2019-10-07T15:16:02Z

Changing resolution and then changing it again before the video has finished loading causes the playback time to reset to 0:00. This bug is not present in the latest app release.

what kind of usage scenario is this? 😀 do you consider this blocking? I am not even fast enough at switching between resolutions to reproduce that..

Stypox · 2019-10-07T15:52:32Z

I was trying to play a video with low internet, so I had to switch resolution, but I pressed on the wrong one so I got this problem. I agree this is not blocking, but if it's just a small problem fixable in no time it could as well be fixed. Though if it would be too much of a hassle to fix it then nevermind.

Redirion · 2019-10-08T04:41:59Z

I have compared MainFragment with the other Fragment classes and added a null check that is inline with the other onDestroy methods as a simple fix. I have replaced the debug apk for retesting.
(This might sound as the lazy fix, but was also the most reasonable I think 😄)

Redirion · 2019-10-10T08:53:52Z

@TobiGr the winter semester has begun, so I understand that your spare time gets limited. Could you try to prepare a RC so that testing AndroidX and ExoPlayer 2.10 gets more traction? Thank you!

TobiGr · 2019-10-10T12:00:33Z

Sorry, for the late response, I though you were trying to fix the issue mentioned by @Stypox. But I agree that this is not blocking. Nevertheless it should be fixed.

Redirion · 2019-10-10T12:03:30Z

Sorry, for the late response, I though you were trying to fix the issue mentioned by @Stypox. But I agree that this is not blocking. Nevertheless it should be fixed.

But I did a commit with a null check to fix the crash. I explained it in a comment here and in the AndroidX PR to you. (you just merged that commit as well, as It was pushed here)

TobiGr · 2019-10-10T12:05:11Z

But I did a commit with a null check to fix the crash. I explained it in a comment here and in the AndroidX PR to you.

Yes, I saw that. Thank you :) But I meant this one;

Changing resolution and then changing it again before the video has finished loading causes the playback time to reset to 0:00. This bug is not present in the latest app release.

Redirion · 2019-10-10T12:09:56Z

@TobiGr
I thought that was the same issue, as I was able to reproduce the bug by wildly rotating the screen. The error message did not always appear (it was hidden by the rebuild fragment) but playback was reset.

@Stypox are you still able to reproduce the playback reset bug with the latest debug apk?

btw. he did a "thumps up" on my comment about the null fix so I thought the issue was resolved for him.

TobiGr · 2019-10-10T12:13:04Z

Oh yes. I cannot repro it with latest comment either. Before I was able to do so. Perfect 👍

Stypox · 2019-10-10T12:13:57Z

No, it seems to be fixed, thanks :-)

Robin added 4 commits October 7, 2019 11:18

Update to ExoPlayer 2.10.5

dcd5197

Fixed deprecations

87eab2a

Update okhttp to match ExoPlayer

bf35387

Make use of isPlaying feature of ExoPlayer 2.10.5

50b51f9

TobiGr reviewed Oct 7, 2019

View reviewed changes

app/src/main/java/org/schabi/newpipe/player/mediasession/PlayQueuePlaybackController.java Outdated Show resolved Hide resolved

app/src/main/java/org/schabi/newpipe/player/playback/CustomTrackSelector.java Outdated Show resolved Hide resolved

Apply suggestions from code review

7aeb1ec

Co-Authored-By: Tobias Groza <TobiGr@users.noreply.github.com>

TobiGr mentioned this pull request Oct 7, 2019

Migrate to AndroidX #2685

Merged

1 task

fix NPE, fix 'wrong' constant, avoid unnecessary nulling

b2b32ce

TobiGr approved these changes Oct 10, 2019

View reviewed changes

TobiGr merged commit 28ed987 into TeamNewPipe:dev Oct 10, 2019

TobiGr mentioned this pull request Oct 10, 2019

Release 0.17.4 #2710

Merged

Redirion deleted the exoplayer2105 branch October 10, 2019 12:23

TobiGr mentioned this pull request Oct 11, 2019

Release 0.17.4 #2715

Closed

wb9688 mentioned this pull request Apr 26, 2020

Playback speed performance regression. #3493

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to ExoPlayer 2.10.5 #2697

Update to ExoPlayer 2.10.5 #2697

Redirion commented Oct 7, 2019 •

edited

Loading

TobiGr commented Oct 7, 2019

Redirion commented Oct 7, 2019 •

edited

Loading

TobiGr commented Oct 7, 2019 •

edited

Loading

TobiGr commented Oct 7, 2019

Redirion commented Oct 7, 2019 •

edited

Loading

TobiGr commented Oct 7, 2019

TobiGr left a comment

TobiGr commented Oct 7, 2019

Redirion commented Oct 7, 2019

Stypox commented Oct 7, 2019 •

edited

Loading

Pentaphon commented Oct 7, 2019

Redirion commented Oct 7, 2019 •

edited

Loading

Stypox commented Oct 7, 2019

Redirion commented Oct 8, 2019

Redirion commented Oct 10, 2019 •

edited

Loading

TobiGr commented Oct 10, 2019

Redirion commented Oct 10, 2019 •

edited

Loading

TobiGr commented Oct 10, 2019 •

edited

Loading

Redirion commented Oct 10, 2019 •

edited

Loading

TobiGr commented Oct 10, 2019

Stypox commented Oct 10, 2019

Update to ExoPlayer 2.10.5 #2697

Update to ExoPlayer 2.10.5 #2697

Conversation

Redirion commented Oct 7, 2019 • edited Loading

TobiGr commented Oct 7, 2019

Redirion commented Oct 7, 2019 • edited Loading

TobiGr commented Oct 7, 2019 • edited Loading

Exception

TobiGr commented Oct 7, 2019

Redirion commented Oct 7, 2019 • edited Loading

TobiGr commented Oct 7, 2019

TobiGr left a comment

Choose a reason for hiding this comment

TobiGr commented Oct 7, 2019

Redirion commented Oct 7, 2019

Stypox commented Oct 7, 2019 • edited Loading

Pentaphon commented Oct 7, 2019

Redirion commented Oct 7, 2019 • edited Loading

Stypox commented Oct 7, 2019

Redirion commented Oct 8, 2019

Redirion commented Oct 10, 2019 • edited Loading

TobiGr commented Oct 10, 2019

Redirion commented Oct 10, 2019 • edited Loading

TobiGr commented Oct 10, 2019 • edited Loading

Redirion commented Oct 10, 2019 • edited Loading

TobiGr commented Oct 10, 2019

Stypox commented Oct 10, 2019

Redirion commented Oct 7, 2019 •

edited

Loading

Redirion commented Oct 7, 2019 •

edited

Loading

TobiGr commented Oct 7, 2019 •

edited

Loading

Redirion commented Oct 7, 2019 •

edited

Loading

Stypox commented Oct 7, 2019 •

edited

Loading

Redirion commented Oct 7, 2019 •

edited

Loading

Redirion commented Oct 10, 2019 •

edited

Loading

Redirion commented Oct 10, 2019 •

edited

Loading

TobiGr commented Oct 10, 2019 •

edited

Loading

Redirion commented Oct 10, 2019 •

edited

Loading