Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for Licenses page #6296

Closed
3 tasks done
skyGtm opened this issue May 14, 2021 · 3 comments · Fixed by #6314
Closed
3 tasks done

Suggestions for Licenses page #6296

skyGtm opened this issue May 14, 2021 · 3 comments · Fixed by #6314
Assignees
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface

Comments

@skyGtm
Copy link

skyGtm commented May 14, 2021

Checklist

Describe the feature you want

In Third-Party Licenses:

  1. Single click shows licenses dialog directly and long click shows a popup menu with only two options.(here I think the Long Click action is useless)
    => I think (instead of long click) it would be better to have single click show the popup menu and user can choose to goto website or show licenses dialog.(Picture 1)

  2. And the title of popup menu feels like its the clickable item (though it is UPPERCASE, it doesnot standout)
    => My suggestions are using different background tint for title and list items of popup menu OR removing the title, because there is ripple animation already to give user feedback.(Picture 2)

Is your feature request related to a problem? Please describe it

I wanted to know what was the purpose of those libraries, and clicked to know about it. But only the license dialog was showing. I didn't know about the long press to show popup menu existed. So, I google searched each entry on the list and read their corresponding Github description.

Additional context

long_press

no_title

How will you/everyone benefit from this feature?

In future, May be someone want to know about the library used in the app and want to directly goto corresponding Github page in just single click.

@skyGtm skyGtm added the feature request Issue is related to a feature in the app label May 14, 2021
@TobiGr
Copy link
Contributor

TobiGr commented May 14, 2021

that adds one step more the read the license. I suggest to add the link to the webview. just another option. next to "ok" to open the website.

@TobiGr TobiGr added good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface labels May 14, 2021
@Peyman-hme
Copy link
Contributor

Hi, Can i work on this as my first issue?

@TobiGr
Copy link
Contributor

TobiGr commented May 15, 2021

@Peyman-hme Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants