Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amoled support #4148

Closed
ghost opened this issue Aug 17, 2020 · 13 comments
Closed

Amoled support #4148

ghost opened this issue Aug 17, 2020 · 13 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@ghost
Copy link

ghost commented Aug 17, 2020

Describe the feature you want

Full Pitch black UI support for amoled devices to save battery. Currently the black theme still leaves a lot of UI elements colored like the top bar.

Is your feature request related to a problem? Please describe it

Not exactly but yes high battery consumption.

Additional context

How will you/everyone benefit from this feature?

The extra battery life would be worth for every amoled user.

@opusforlife2
Copy link
Collaborator

Test the apk in #3632 and reply if it doesn't match your expectations.

@ghost
Copy link
Author

ghost commented Aug 17, 2020

#3632 doesn't match my expectations @opusforlife2 as it still leaves things like the top bar colored.

@opusforlife2
Copy link
Collaborator

Thanks!

@opusforlife2 opusforlife2 reopened this Aug 17, 2020
@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Oct 10, 2020
@B0pol
Copy link
Member

B0pol commented Nov 21, 2020

The extra battery life would be worth for every amoled user.

The "extra battery life" is really really small

@ghost
Copy link
Author

ghost commented Nov 21, 2020

@B0pol it piles up as newer phones screen gets bigger and bigger and people tend to use newpipe for quite a good chunk of time so pretty sure it would be worth it.

@triallax
Copy link
Contributor

I would expect most people to spend most of their time in NewPipe watching stuff, not navigating the app, so even if you disregard @B0pol's comment, the gains are probably very negligible.

@andrewbanchich
Copy link

I'd love this just for the aesthetic.

@ghost
Copy link
Author

ghost commented Nov 21, 2020

@mhmdanas tbh for me its just worth it for the look, all my other apps are all black. And i usually watch videos while reading the comments so theres that

@triallax
Copy link
Contributor

I am not against adding this; I'm just saying that the battery life gains from this change are extremely negligible.

@triallax triallax mentioned this issue Apr 21, 2021
@k9janer
Copy link

k9janer commented Jun 8, 2021

I would also appreciate a completely black title bar for night time use and to protect OLED and Plasma tvs.

Also I think NewPipe looks really sleek in black 😁
nsmail-1_crop_crop

@SameenAhnaf SameenAhnaf mentioned this issue Sep 11, 2021
3 tasks
@litetex
Copy link
Member

litetex commented Nov 3, 2021

Closing this issue.

Why?

  • customization of themes #6272 (comment)
  • There is no such thing as "Amoled support" - It's more like "Better optimization for amoled displays"
  • As seen in Amoled support #4148 (comment) there is no too little battery saving.
  • "... still leaves a lot of UI elements colored like the top bar"
    • The search-bar at the top is currently the only place that is large enough (uses ~7% of the screen on my phone) to be considered in this issue.
    • I don't think that really matters considering battery usage.
      When using NewPipe you want to watch videos. When watching a video there is little to no UI of the app visible. So the battery usage then depends on the type of video you are watching - Nothing we as app developers can influence.

Feel free to leave a comment.

@litetex litetex closed this as completed Nov 3, 2021
@triallax
Copy link
Contributor

triallax commented Nov 6, 2021

@litetex I think this issue should be kept open. The major reasons you closed this issue for are not valid. You didn't take into consideration that people also want this for its aesthetic value:

#4148 (comment)
#4148 (comment)

In additon, regarding your first bullet point, the issue Stypox commented on was requesting that the user be allowed to customize the app's theme to a high granularity; it's not relevant to this issue.

Not related to your comment, but I would also like to add that adding a new pitch black theme is better than changing the current theme IMO, as I can imagine that many people will still prefer the current look.

@opusforlife2
Copy link
Collaborator

@mhmdanas It would be better to open a new issue just asking for a full black theme. This thread is too much about the battery saving angle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

6 participants