-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amoled support #4148
Comments
Test the apk in #3632 and reply if it doesn't match your expectations. |
#3632 doesn't match my expectations @opusforlife2 as it still leaves things like the top bar colored. |
Thanks! |
|
@B0pol it piles up as newer phones screen gets bigger and bigger and people tend to use newpipe for quite a good chunk of time so pretty sure it would be worth it. |
I would expect most people to spend most of their time in NewPipe watching stuff, not navigating the app, so even if you disregard @B0pol's comment, the gains are probably very negligible. |
I'd love this just for the aesthetic. |
@mhmdanas tbh for me its just worth it for the look, all my other apps are all black. And i usually watch videos while reading the comments so theres that |
I am not against adding this; I'm just saying that the battery life gains from this change are extremely negligible. |
Closing this issue. Why?
Feel free to leave a comment. |
@litetex I think this issue should be kept open. The major reasons you closed this issue for are not valid. You didn't take into consideration that people also want this for its aesthetic value: #4148 (comment) In additon, regarding your first bullet point, the issue Stypox commented on was requesting that the user be allowed to customize the app's theme to a high granularity; it's not relevant to this issue. Not related to your comment, but I would also like to add that adding a new pitch black theme is better than changing the current theme IMO, as I can imagine that many people will still prefer the current look. |
@mhmdanas It would be better to open a new issue just asking for a full black theme. This thread is too much about the battery saving angle. |
Describe the feature you want
Full Pitch black UI support for amoled devices to save battery. Currently the black theme still leaves a lot of UI elements colored like the top bar.
Is your feature request related to a problem? Please describe it
Not exactly but yes high battery consumption.
Additional context
How will you/everyone benefit from this feature?
The extra battery life would be worth for every amoled user.
The text was updated successfully, but these errors were encountered: