Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "gesture" volume and brightness control by default #3713

Closed
ilia3101 opened this issue Jun 1, 2020 · 40 comments
Closed

Disable "gesture" volume and brightness control by default #3713

ilia3101 opened this issue Jun 1, 2020 · 40 comments
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)

Comments

@ilia3101
Copy link

ilia3101 commented Jun 1, 2020

It's really annoying and an acquired taste. Most people for sure hate it. Much less useful than it is annoying (bad ux).

BTW newpipe is amazing and I love it, probably my favourite app. This is just the only thing that bothers me, I always have to disable it.

@ilia3101 ilia3101 added the feature request Issue is related to a feature in the app label Jun 1, 2020
@Stypox
Copy link
Member

Stypox commented Jun 1, 2020

I also never use gestures, but from my experience assumptions like "most people hate them" often turn out to be wrong. Vlc has them enabled by default, too, so I think keeping the current behavour is ok

@B0pol
Copy link
Member

B0pol commented Jun 1, 2020

I disagree. Personally i really enjoy these gestures, for example luminosity: you first have to open the notification menu, but also set the luminosity in it. That means you may need to set the luminosity twice, because you didn't see how it renders in live.
With gestures, just swipe. Wow the video is too bright, let's just swipe down. Easy and fast.

@ghost
Copy link

ghost commented Jun 1, 2020

I hate the gestures. My mom also has problems with these controls, I told her about the gestures but it always messes up her viewing experience when just touching the screen and I have to run down the stairs to show her how it works and reset everything. Finally I just turned it off for her. Which means the default should be OFF here.

@ilia3101
Copy link
Author

ilia3101 commented Jun 1, 2020

Sorry if I came off rude at all. @Stypox You are right, assumptions are hard to make correctly. Maybe a poll of newpipe users could be done?

And another issue with gestures that I forgot to mention: quickly swiping down from the top of the screen just to see the notification icons and clock triggers the gestures too, and volume goes way down sometimes.

@Stypox
Copy link
Member

Stypox commented Jun 1, 2020

Maybe a poll of newpipe users could be done?

I was thinking about this, too. Maybe something on the website? Would we be allowed to collect feedback there given the GDPR regulation? @TobiGr @TheAssassin

And another issue with gestures that I forgot to mention: quickly swiping down from the top of the screen just to see the notification icons and clock triggers the gestures too, and volume goes way down sometimes.

This is fixed in 0.19.4

@TheAssassin
Copy link
Member

Maybe a poll of newpipe users could be done?

There's no reason not to do so. Just make sure to use a privacy-friendly tool, which also has a proper privacy policy.

@wb9688
Copy link
Contributor

wb9688 commented Jun 1, 2020

What about just using GitHub reactions? I.e. react with 👍 or 👎 on this message.

@Stypox
Copy link
Member

Stypox commented Jun 1, 2020

@wb9688 how many people who use NewPipe, also take a look at its repository to check issues and give feedback? Some surely do, but most people don't even know how GitHub works. I meant that there could be a more mainstream way to vote on active issues, with a proper ui and accessible by anyone, so that the vote can be more representative of the user base.

@wb9688
Copy link
Contributor

wb9688 commented Jun 1, 2020

@Stypox: How many people look at our website? I know I basically never do. Also, it not hard to click on 👎 or 👍. And with our own website, how will we guarantee someone only votes once?

@Stypox
Copy link
Member

Stypox commented Jun 1, 2020

Maybe we could put a button in NewPipe's drawer advertising that users can cast their vote on the website

@ghost
Copy link

ghost commented Jun 1, 2020

I actually think we should just go to Reddit, for example, /r/privacytoolsio which has privacy minded people and whom actually use NewPipe for obvious reasons. And make the poll from there.

I created a POLL

@Stypox
Copy link
Member

Stypox commented Jun 1, 2020

@ingingin there are no checks for duplicate votes, if I wanted I could just vote 100 times. Using Reddit for polls seems good idea, does it support built-in polls (maybe through bots)?

@ghost
Copy link

ghost commented Jun 1, 2020

Reddit doesn't use polls, which is sad. I did find Redditpoll But it's HTTP, and isn't a privacy minded service either. That poll I gave you is the only one privacy focused- which is also why there probably isn't any way to detect 'duplicate votes'. It doesn't store cookies or collect information, like IPs

@TheAssassin
Copy link
Member

@ingingin random tools make no sense, and please don't create polls on behalf of the NewPipe project, this gives a wrong impression and we take no responsibility for third party poll stuff. Your enthusiasm is admirable, but maybe take a step back, we'll set up a proper poll if we need one.

Reddit makes no sense either. Just gives people access who want to sign up with such a service.

@ghost
Copy link

ghost commented Jun 1, 2020

@TheAssassin What the fuck, don't talk to me like that. I am trying to help but would rather give you the finger, I am trying to help here, creating a poll is what I did to show how it looks. Take all the credit if you care so much. I was never invited anyways

@ghost
Copy link

ghost commented Jun 1, 2020

You even said it yourself;

There's no reason not to do so. Just make sure to use a privacy-friendly tool, which also has a proper privacy policy.

And I found one, be glad now

@ilia3101
Copy link
Author

ilia3101 commented Jun 2, 2020

@ingingin You are not as important as you think you are. Newpipe team have zero obligation to instantly accept things done on their behalf. They don't even get to see the results of that poll you, some 15 day old user, created.

@androidSwDev099
Copy link

androidSwDev099 commented Jun 2, 2020

The gesture settings are retained through updates for me, so I don't understand the issue. I have the volume gesture on and the brightness gesture off. Default on makes sense so new users know they exist.

@puppykickr
Copy link

puppykickr commented Jun 3, 2020 via email

@androidSwDev099
Copy link

New users should go through the settings to learn what they can do with the app. ☺️

@ilia3101
Copy link
Author

ilia3101 commented Jun 3, 2020

If something puts off new users, it should be disabled by defualt. ☺️

(so we should find out if it does)

@androidSwDev099
Copy link

Won't ever be able to please all users no matter what the default settings are.

@ilia3101
Copy link
Author

ilia3101 commented Jun 3, 2020

It's confusing because it is a very unusual software control, that's just the truth. A feature that is very likely to confuse or infuriate some new users is better turned off by default.

At the very least, an explanation/some kind of tip should show up when the app is first opened.

@puppykickr describes the situation perfectly.

Phone slips in the hand? Volume all the way up. Or vise-versa. Change hands
holding device? Brightness all the way down. Or vice-versa. Each is
annoying.

@B0pol
Copy link
Member

B0pol commented Jun 3, 2020

Unusual? Definitely not unusual for video players, see VLC, MX Player, MPV, jellyfin…

@ChiefMikeK
Copy link

Personally, myself a long time user, I despise the gestures. There is not much more annoying than having the volume and brightness controls screwed up each time the screen is touched. Phone slips in the hand? Volume all the way up. Or vise-versa. Change hands holding device? Brightness all the way down. Or vice-versa. Each is annoying. Perhaps an anouncement toast upon initial app start to notify new users of the presence of this 'feature'. I, for one, thank God that there is a way to turn this off, in addition for NewPipe as a whole. Grant Ryan Swan (puppykicker)

My thoughts🏝 A delay of a few hundred milliseconds upon accidentally touching the screen but, only for an increase in volume / luminous

I prefer to have an instant lowering of volume and dislike an accidental full volume!

@theFireProject
Copy link

I'm using the gestures. I'm used to it from VLC and I think it's useful if your phone is standing somewhere and the volume keys are on the wrong side, at the bottom so you can't reach them.
Also my phone has a video enhancer mode which makes the screen massively brighter on the same brightness value, so it is useful to be able to readjust this within the player. Also I don't like to pull down the bright, white notification bar to tune the brightness while watching videos cause it's blinding.

@puppykickr
Copy link

@ChiefMikeK
I kind of like your idea.
Especially if the delay was adjustable, similar to how it is done on a keyboard alternate.

The more I think of it, the more I like it.

But I would also want the delay for decreases, as well.

There could even be a different time allotment for the longpress required for each.

Obviously this would increase the complexity of the app, and in setting it up.

But, as stated above by others, many popular video apps have this feature- and almost every keyboard app has a similar feature that deals with the timing of a longpress.

@markus2120
Copy link

+1 for Brightness gesture be disabled (by default). Not sure if you need to remove it altogether.

Volume gesture IMHO you can keep it.

@ilia3101
Copy link
Author

ilia3101 commented Jun 10, 2020

Unusual? Definitely not unusual for video players, see VLC, MX Player, MPV…

Sure, but Google/Netflix/Amazon/Apple would have added such a feature to their video-related apps by now if it benefitted the user experience. These companies do research on this stuff because user experience can affect their profits.

@androidSwDev099
Copy link

androidSwDev099 commented Jun 10, 2020

Unusual? Definitely not unusual for video players, see VLC, MX Player, MPV…

Sure, but Google/Netflix/Amazon/Apple would have added such a feature to their video-related apps by now if it benefitted the user experience. These companies do research on this stuff because user experience can affect their profits.

I was using both the brightness and volume controls on my LG phones video player today. It benefited me to have those controls there as I used them both while watching a videos. No amount of research is going to satisfy all users and since these gestures can be disabled in NewPipe - everyone can be happy. I'm sure this debate will go on endlessly despite the fact that they can be disabled.

@MD77MD
Copy link

MD77MD commented Jul 3, 2020

Unusual? Definitely not unusual for video players, see VLC, MX Player, MPV…

Sure, but Google/Netflix/Amazon/Apple would have added such a feature to their video-related apps by now if it benefitted the user experience. These companies do research on this stuff because user experience can affect their profits.

We wouldn't be using newPipe if they did things right... big companys with stupid minds... the only thing they are good at is collecting 💰

beside, could you be more specific to what apps are you referring to?

@ilia3101
Copy link
Author

would wouldn't be using newPipe if they did things right... big companys with stupid minds... the only thing they are good at is collecting 💰

That's irrelevant. What's relevant is that they make apps most people can happily use in the default configuration.

And this feature, is really annoying. I am almost certain it has put some new users off. I know just how quickly I'll stop using an app if I dislike something. If not for the popup player, I probably would've given up on newpipe instantly.

A setting for Gestures can be provided in this introduction, with a slide dedicated to showing the gesture controls.

This would be a really great solution.

@opusforlife2 opusforlife2 added player Issues related to any player (main, popup and background) and removed more info needed labels Oct 10, 2020
@MD77MD
Copy link

MD77MD commented Oct 11, 2020

That's irrelevant. What's relevant is that they make apps most people can happily use in the default configuration.

Yes it is, if we were happy by the way they make things, you and me would not be here... we wouldn't even need to have newPipe...

anyway, i think a clear indication to what people like more, could be extracted from what every video app out there has by default, that is gestures on by default. on the other hand, if most people did not like gestures, developers of those apps would have so much complaints, that they would have them off by default, but they don't. so this should definitely be the default setting .

@krushia
Copy link

krushia commented Nov 23, 2020

The easiest way to find out what people prefer is to change it and see who complains.

@MD77MD
Copy link

MD77MD commented Nov 24, 2020

The easiest way to find out what people prefer is to change it and see who complains.

what are talking about...isn't this obvious already?

@krushia
Copy link

krushia commented Dec 1, 2020

@MD77MD Nobody has ever opened an issue to request these gestures be enabled by default. There are however several closed issues that were caused by gestures.

Commenting in opposition to an opened issue is less noteworthy than one being created (many of you are here only because you got a watched project notification). The only way to get comparable feedback from users is to disable gestures by default.

@B0pol B0pol closed this as completed Dec 1, 2020
@crozone
Copy link

crozone commented Jan 18, 2021

Found this issue after slipping on newpipe and accidentally maxing the volume on my bluetooth headphones. Not only are the gestures incredibly annoying, they are dangerous to the users hearing.

VLC is also plagued by similar gestures, for both mobile and desktop. Personally I have never found them to be anything but an annoyance and something to immediately disable after a fresh install.

The issues with the UX of these features are threefold.

  • They aren't discoverable by simply looking at the UI, only by accidentally changing the volume or brightness drastically can the user discover these features even exist. The features aren't consistent with the placement of other features in the menu, such as resolution and speed control.

  • The actions the gestures perform are already baked into the Android UI. Users already know how to change their brightness and volume on their devices easily with physical buttons or the notification dropdown. The gestures are completely redundant.

  • The gestures are easily triggered by accident and the result can range from annoying (brightness being set too high or low), to dangerous (headphones being set to maximum volume instantaneously).

I would urge the developers to reconsider this issue and potentially disable the gestures by default.

@thansk
Copy link

thansk commented Feb 4, 2021

I am happy with the gestures, they are extremely useful and convenient and wouldn't have found out about them if they weren't enabled by default.

@crozone
Copy link

crozone commented Feb 8, 2021

wouldn't have found out about them if they weren't enabled by default.

This is indicative of poor UI design that doesn't prioritise discoverability. Annoying users with hidden behaviour is not a substitute for a visual indicator that flags the presence of a feature.

@shscs911
Copy link

As a long-time user of MX Player, I personally found the brightness and volume gestures extremely intuitive. Just my opinion, but it would be awesome, if there was a setting to make the Brightness and Volume set by gestures to persist across sessions (Though I don't think many people would like that). Thanks for all your hardwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests