Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Why you add PIP mode to play the video in the Overlay #2455

Closed
3 tasks
Mikesew1320 opened this issue Jul 10, 2019 · 8 comments
Closed
3 tasks

[REQUEST] Why you add PIP mode to play the video in the Overlay #2455

Mikesew1320 opened this issue Jul 10, 2019 · 8 comments
Labels
device/software specific Issues that only happen on some devices or with some specific hardware/software feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)

Comments

@Mikesew1320
Copy link

@Mikesew1320
Copy link
Author

It becomes more better and valuable when you add this feature to the app, also try to make it work at least for Android 5 and greater. This helpless to be used by more devices.

@EmberHeartshine
Copy link

Picture-in-Picture is weaksauce compared to the pop-up window.

@Mikesew1320
Copy link
Author

Mikesew1320 commented Jul 15, 2019

Ok, what about the pop up window. I think it's more important for users havingr lower android versions.

Can you add it or not?

@Mikesew1320
Copy link
Author

Mikesew1320 commented Jul 15, 2019 via email

@EmberHeartshine
Copy link

EmberHeartshine commented Jul 18, 2019

I think there's a bit of a miscommunication. Picture-in-Picture is an Android Oreo feature allowing video-centric apps to continue playing in a "minimized" view, similar to NewPipe's pop-up player but with fewer options. NewPipe already implements its own version of this via the pop-up player, and it works on every Android version that NewPipe supports.

@Gymcap
Copy link

Gymcap commented Jul 28, 2019

I have to agree. Adding PIP seems like a downgrade compared to the existing overlay.

@Stypox Stypox added feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Aug 27, 2019
@Stypox Stypox added the device/software specific Issues that only happen on some devices or with some specific hardware/software label Oct 1, 2019
@Scrumplex
Copy link

What about making this configurable? Meaning: One can choose between them in the settings (if on Oreo or newer)

@B0pol
Copy link
Member

B0pol commented May 10, 2020

Duplicate of #2223 #712

@B0pol B0pol closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device/software specific Issues that only happen on some devices or with some specific hardware/software feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

6 participants