You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Graphix does not guarantee the runnability and deterministic properties of a pattern when it is passed to a simulator or QPU. It would be beneficial if these fundamanetal properties are ensured during the pattern generation process.
Describe the feature you'd like
A clear and concise description of what you want to happen.
One possible way to do this is to generate a pattern from the underlying graph and flowlike objects(including causal flow, gflow, and pauli flow). Flows can be understood as a feedforward protocol that ensures deterministic property of MBQC.
Generate every pattern through the above generator
Implement flags in the pattern class such as pattern.is_deterministic and pattern.is_runnable.
I plan to refactor some methods in the pattern class to clarify which operations preserve the properties. For example, standardize and shift_signals preserve the properties, but add does not. I will implement a property-preserving pattern concatenation method for those who want to directly edit the pattern.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
That's something we have in mind and will do soon. The easiest way seems to check we don't offend runnability when adding a command without reference to the graph and whether it has flow.
Nodes were not removed from `NodeIndex` dictionary which allow
non-runnable patterns to use wrong nodes by mistake.
Related to TeamGraphix#193 (runnability issues).
…214)
Nodes were not removed from `NodeIndex` dictionary which allow
non-runnable patterns to use wrong nodes by mistake.
Related to #193 (runnability issues).
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Graphix does not guarantee the runnability and deterministic properties of a pattern when it is passed to a simulator or QPU. It would be beneficial if these fundamanetal properties are ensured during the pattern generation process.
Describe the feature you'd like
A clear and concise description of what you want to happen.
One possible way to do this is to generate a pattern from the underlying graph and flowlike objects(including causal flow, gflow, and pauli flow). Flows can be understood as a feedforward protocol that ensures deterministic property of MBQC.
generator.generate_from_graph
) with an arbitrary flowlike object(related to Add optional argument to pass gflow ingenerate_from_graph()
#120 )pattern.is_deterministic
andpattern.is_runnable
.I plan to refactor some methods in the pattern class to clarify which operations preserve the properties. For example,
standardize
andshift_signals
preserve the properties, butadd
does not. I will implement a property-preserving pattern concatenation method for those who want to directly edit the pattern.Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: