better input validation for bookmarks dialog #4343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishnuSanal
added
the
pr-awaiting-initial-review
|
@VishnuSanal fix CI |
|
codacy cries about using a label in return. seems unreasonable. |
EmmanuelMess
requested changes
Feb 9, 2025
|
|
||
| val result = isValidBookmark(editText1.text.toString(), editText2.text.toString()) | ||
| if (!result.first) { | ||
| Toast.makeText( |
There was a problem hiding this comment.
this should be a snackbar per Android guidelines https://developer.android.com/guide/topics/ui/notifiers/toasts
| @@ -174,7 +174,7 @@ int contains(String[] a, ArrayList<String[]> b) { | |||
| if (b == null) return -1; | |||
| int i = 0; | |||
| for (String[] x : b) { | |||
| if (x[0].equals(a[0]) && x[1].equals(a[1])) return i; | |||
| if (x[0].equals(a[0]) || x[1].equals(a[1])) return i; | |||
There was a problem hiding this comment.
Okay, this (DataUtils::constains) function is very opaque, what is it actually doing? Whats the fix doing?
I think we either need to ignore the issue project wise or ignore on the line to actually be able to merge. |
VishnuSanal
added
pr-requested-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4337, #4336, #4335 & #4334