Range selection

[ghost]

PR Info

I've added a "Select between" action item when 2 or more files are selected. The wording is not set in stone, I'm open to suggestions

Issue tracker

Fixes #2070

Release

Addresses release/

Test cases

• Covered

Manual testing

• Done

If yes,

• Device: Motorola Moto E4
• OS: Android 7.1.1

Build tasks success

Successfully running following tasks on local

• ./gradlew assembledebug
• ./gradlew spotlessCheck

[EmmanuelMess]

No unnecessary logs please, and necessary ones should have the simple class name as tag.

[EmmanuelMess]

This works by checking if two items are selected, then a button appears in the dropdown so that if the user presses it, all items between the two preselected items get selected? That seems very unintuitive.

[EmmanuelMess]

It also doesn't allow for the selection of more than one range
Edit: Sorry, I should test before saying this. Will do tomorrow.

[ghost]

No unnecessary logs please, and necessary ones should have the simple class name as tag.

Sorry, I was messing around with the code and didn't see those made it in, removed them and squashed the commit.

This works by checking if two items are selected, then a button appears in the dropdown so that if the user presses it, all items between the two preselected items get selected? That seems very unintuitive.

Yes, I haven't used a feature like this in other file managers before, this is the first way that came to mind. Definitely open for suggestions here.

[EmmanuelMess]

Okay, it seems this is the way ES File Manager does range selection. I personally would prefer a system more like the range selection for Google Photos (Edit: long press on a file until it is selected, then drag down to select more). @TranceLove @VishalNehra what do you think?

[VishalNehra]

Agreed here, need something like Google photos. I think there's an API which supports drag and pass us all the ui elements present below it. We can make use of that api. Maybe just support whatever adapter elements are there at one screen for now, and support for list auto-scrolling if drag comes to bottom part of the screen can be added later.

[VishalNehra]

No work being done here? Closing...