Make output of MPI test visible #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/mpi-test
branch
3 times, most recently
from
53b2d16
to
7e6e61f
Compare
|
Thanks to #77 I've been able to reduce the size of the grid, to make GitHub Actions suffer much less during the MPI test. This saves about 1-2 minutes of CI for each job compared to the current test on |
tkoskela
approved these changes
May 27, 2020
| # Flush a newline | ||
| println() | ||
|
|
||
| # Run the command | ||
| rm("tdac.h5"; force = true) | ||
| tdac(TDAC.tdac_params(; nprt = 2 * my_size, nobs = 36, padding = 0, enable_timers = true, verbose = true)) | ||
| tdac(params(; nprt = 2 * my_size, nobs = 36)) |
There was a problem hiding this comment.
Just curious, how/why does this work? I thought the struct is immutable. Is this creating a new struct off of params?
There was a problem hiding this comment.
Yes, it's immutable, but I've defined a method above to do this: it creates a new instance of tdac_params, which changes the fields passed as arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.