Introduce timers with the @timeit_debug macro
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows enabling/disabling timers - Disabled by default
giordano
approved these changes
May 18, 2020
|
|
||
| tsunami_update!(@view(states.particles[:,ip]), hm, hn, fn, fm, fe, gg, params) | ||
| @timeit_debug timer "Particle State Update" begin |
There was a problem hiding this comment.
I didn't try, but I think you can put @timeit_debug timer "Particle State Update" right before the for loop in the next line? That line becomes a bit long, but at least you don't need a whole new begin-end block here.
There was a problem hiding this comment.
Ideally I'd put the timer on the line inside the loop, but I think there was some issue with threads
| @@ -91,6 +91,7 @@ Base.@kwdef struct tdac_params{T<:AbstractFloat} | |||
| obs_noise_amplitude::T = 1.0 | |||
|
|
|||
| random_seed::Int = 12345 | |||
| enable_timers::Bool = false | |||
There was a problem hiding this comment.
Is it worth documenting it or you prefer to keep this field out of casual users' reach?
There was a problem hiding this comment.
Oh, right, forgot to update the docstring
giordano
changed the title
@timeit_debug macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm tired of maintaining separate branches with timers. I discovered there is a
@timeit_debugmacro that can be enabled/disabled. I added a parameter that enables the timers and set it to disabled by default. I think we can merge this into master, the only downside I see is it makes the code a bit cluttered.