Add more benchmarks #154
Merged
Add more benchmarks #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/more-benchmarks
branch
2 times, most recently
from
d403b57
to
c40e394
Compare
giordano
commented
Feb 25, 2021
| SUITE["base"]["get_log_weights!"] = @benchmarkable ParticleDA.get_log_weights!(weights, truth_observations, model_observations, $(filter_params.weight_std)) setup=(weights = Vector{Float64}(undef, nprt_per_rank); truth_observations=ParticleDA.update_truth!(model_data, nprt_per_rank); model_observations = ParticleDA.get_particle_observations!(model_data, nprt_per_rank)) | ||
| SUITE["base"]["normalized_exp!"] = @benchmarkable ParticleDA.normalized_exp!(weights) setup=(weights = rand(filter_params.nprt)) | ||
| SUITE["base"]["resample!"] = @benchmarkable ParticleDA.resample!(resampling_indices, weights) setup=(resampling_indices = Vector{Int}(undef, filter_params.nprt); weights = rand(filter_params.nprt)) | ||
| # SUITE["base"]["copy_states!"] = @benchmarkable ParticleDA.copy_states!($(ParticleDA.get_particles(model_data)), $(bootstrap_filter_data.copy_buffer), $(bootstrap_filter_data.resampling_indices), $(my_rank), $(nprt_per_rank)) |
There was a problem hiding this comment.
This is failing inside MPI.Irecv! but I don't understand why. Not sure it's worth spending more time on this, but I left it commented in case someone wants to get back to this in the future.
giordano
force-pushed
the
mg/more-benchmarks
branch
from
c40e394
to
1eff839
Compare
giordano
commented
Feb 25, 2021
Comment on lines
+16
to
+17
| SUITE["base"] = BenchmarkGroup() | ||
| SUITE["BootstrapFilter"] = BenchmarkGroup() |
There was a problem hiding this comment.
Now we have these two benchmark groups: "base" is common to all filters (I think, let me know if I missed something!), "BootstrapFilter" runs benchmarks for init_filter and run_particle_filter which in #133 will have different implementations for the optimal filters
There was a problem hiding this comment.
What about update_particle_dynamics!?
giordano
force-pushed
the
mg/more-benchmarks
branch
from
1eff839
to
bbb9aa5
Compare
tkoskela
approved these changes
Feb 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.