Update model interface for optimal filter #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed this last week 28feb52 but forgot to open the PR 🤦 Yours is better, it has also tests! 😃 |
|
That's exactly the thing in my TODO! Can we merge it into this PR? |
…ove call to get_obs in update_particle_dynamics!
…into tk/update-model-interface
|
Yes we can! 💪 |
giordano
reviewed
Jan 27, 2021
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
|
I'll mark this as ready for review. The other thing to do in #136 is expose more fields from the model_data struct but we can do that in another PR. |
giordano
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As planned in #136
Split
update_particles!toupdate_particle_dynamics!andupdate_particle_noise!DONE: Now both new functions return the observations which may not be ideal. Would it be better to separate
get_particle_observationsinto a third function?