Revert state split #102
Merged
Revert state split #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
1. Update true state on every process to get true observations 2. Calculate weights in parallel from true observations 3. MPI.Gather the weights instead of model observations
Add options for particle initial state
giordano
reviewed
Jun 19, 2020
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
giordano
approved these changes
Jun 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion today and in #67 we can't make the velocity state variables completely local 😒 . I reverted PR #95 and then cherry-picked the parts that still make sense. I also added the noise back to the velocity state variables, which was removed in #68, but kept the loop over particles.
Sorry this got quite massive, it contains:
Fixes #105 and most likely the issues Alex was having Fixes #92