Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects & archived branches #39

Merged
merged 37 commits into from
Jun 16, 2024
Merged

Redirects & archived branches #39

merged 37 commits into from
Jun 16, 2024

Conversation

severinbratus
Copy link
Contributor

@severinbratus severinbratus commented Jun 14, 2024

Redirects

Introduces a var COPY to indicate if to copy the primary.

Archiving

To archive a branch, include its name in the BRANCHES_ARCHIVED variable. The banner looks like this https://teachbooks.github.io/testable-template/2023/intro.html

TODO

  • A better 404 page

@severinbratus severinbratus marked this pull request as draft June 14, 2024 08:13
Copy link
Member

@Tom-van-Woudenberg Tom-van-Woudenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@severinbratus , awesome!
Af few comments in the code and could you change the next in the summary depending on whether aliases or redirecting is used. In case of the second one:
The book at the website root url is redirecting to the branch branch. Status: status

@Tom-van-Woudenberg Tom-van-Woudenberg marked this pull request as ready for review June 16, 2024 14:17
@Tom-van-Woudenberg Tom-van-Woudenberg removed the request for review from rlanzafame June 16, 2024 14:18
@Tom-van-Woudenberg Tom-van-Woudenberg merged commit 2971b0e into main Jun 16, 2024
@Tom-van-Woudenberg Tom-van-Woudenberg deleted the wip/redirects branch June 16, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants