-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/additions to tcopneumatics #99
Conversation
@PTKu , VAR_IN_OUT |
@runtimevic I am not OK with bloating FB parameters with a long list of structures. We will need to create separate instances of structures in order to be able to use components, it's extra work, that is not necessary if we use properties. The intention here is to make use of OOP design. What you present above is an old-good way of doing components and we have #91 to discuss how to make OOP components usable in the "classical paradigm". |
I gotta agree with @PTKu here. That's just way too many input parameters for a function block...the goal should be to make as simple as possible, but not simpler :) |
VAR_IN_OUT
can then be deleted: InControl : ST_Axis_InControl; (and make them just the methods) and deleted: OutDiag : ST_Axis_OutDiagnosis (and come from the properties); |
TcoRtc
#98 removed Rtc synchronization that produced failed tests.Pneumatic Cylinder
Config, Status
CyclinderConfig
that contains times to reach home/work position (for reporting/alarming/simulation)Status
ofCylinderStatus
as all information is available via TcoTask(done, busy, error...) and diagnostics via TcoTask.Messenger; I just added an action description, but do not see that necessary either.Actions
Action
folder.And in action
Untitled.Project.mp4