Skip to content

Commit

Permalink
update domino package and run tests
Browse files Browse the repository at this point in the history
  • Loading branch information
vinicvaz committed Oct 12, 2023
1 parent 2c4e0fd commit b06579d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/integration-tests-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- main
- dev
- test/*
- fix/tests

jobs:
api-tests:
Expand All @@ -31,9 +32,13 @@ jobs:
with:
install_only: true

- name: Print Current Working Directory
run: |
pwd
- name: Prepare and create cluster.
run: |
domino platform prepare --cluster-name=domino-cluster --workflows-repository=${{secrets.TESTS_WORKFLOWS_REPOSITORY}} --github-workflows-ssh-private-key=None --github-workflows-token=${{ secrets.TESTS_GITHUB_WORKFLOWS_TOKEN }} --github-default-pieces-repository-token=${{ secrets.TESTS_GITHUB_PIECES_TOKEN }} --deploy-mode=local-k8s-dev --local-pieces-repository-path=[] --local-domino-path='' --local-rest-image='domino-rest:test' --local-frontend-image='' --local-airflow-image=''
domino platform prepare --cluster-name=domino-cluster --workflows-repository=${{secrets.TESTS_WORKFLOWS_REPOSITORY}} --github-workflows-ssh-private-key='' --github-workflows-token=${{ secrets.TESTS_GITHUB_WORKFLOWS_TOKEN }} --github-default-pieces-repository-token=${{ secrets.TESTS_GITHUB_PIECES_TOKEN }} --deploy-mode=local-k8s-dev --local-pieces-repository-path=[] --local-domino-path='./src/domino' --local-rest-image='domino-rest:test' --local-frontend-image='' --local-airflow-image=''
domino platform create --install-airflow=False
- name: Install tests dependencies.
Expand Down
8 changes: 0 additions & 8 deletions rest/utils/routing.py

This file was deleted.

3 changes: 2 additions & 1 deletion src/domino/cli/utils/platform.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,10 @@ def create_platform(install_airflow: bool = True, use_gpu: bool = False) -> None
)
)
if platform_config['dev'].get('DOMINO_LOCAL_DOMINO_PACKAGE'):
domino_local_package_absolute_path = Path(platform_config['dev']['DOMINO_LOCAL_DOMINO_PACKAGE']).resolve()
extra_mounts_local_repositories.append(
dict(
hostPath=platform_config['dev']['DOMINO_LOCAL_DOMINO_PACKAGE'],
hostPath=str(domino_local_package_absolute_path),
containerPath=f"/domino/domino_py/src/domino",
readOnly=True,
propagation='HostToContainer'
Expand Down

0 comments on commit b06579d

Please sign in to comment.