Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KeyValueEntry with formatted JSON #6

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

andreia
Copy link
Member

@andreia andreia commented Sep 29, 2024

Replace KeyValueEntry with formatted JSON.

Issue #3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

@willcastillo willcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andreia !

Non-blocker comment: The ViewEntry components will probably get quite long now. You may want to add this

->stickyModalFooter()
->stickyModalHeader()

... to your View action.

Again, thanks lot for your support!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@andreia
Copy link
Member Author

andreia commented Sep 30, 2024

Thank you @andreia !

Non-blocker comment: The ViewEntry components will probably get quite long now. You may want to add this

->stickyModalFooter()
->stickyModalHeader()

... to your View action.

Again, thanks lot for your support!

@willcastillo Sweet, thanks for the suggestion :)
I applied it and merging now

@andreia andreia merged commit 1987e67 into main Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants