Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate indicators #6

Merged
merged 2 commits into from
Aug 5, 2024
Merged

translate indicators #6

merged 2 commits into from
Aug 5, 2024

Conversation

buddhaCode
Copy link

Makes the filter indicator labels translatable.

@@ -6,5 +6,9 @@
'range.options.between' => 'is between',
'range.options.greater_than' => 'is greater than',
'range.options.less_than' => 'is less than',
'range.indicator.equal' => ':label is equal to :value',
'range.indicator.between' => ':label is between :formValue and :toValue',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buddhaCode Awesome! Thank you for all contributions :)

Could you fix the typo :formValue to :fromValue in
':label is between :formValue and :toValue',

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops. sure thing :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@andreia andreia merged commit 7315f02 into TappNetwork:main Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants