Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable logging for whole project and add more logging to connectors #3215

Conversation

mikhail5555
Copy link
Contributor

@mikhail5555 mikhail5555 commented Jul 10, 2024

required for #3213

Adds logging in the following format:

Thread-1 (worker) DEBUG 2024-07-10 11:15:22,820 recipes.connector.worker received item.instance=<ShoppingListEntry: Shopping list entry 77> with item.actionType=<ActionType.CREATED: 1>
Thread-1 (worker) DEBUG 2024-07-10 11:15:22,826 recipes.connector.worker running 1 connectors for item.instance=<ShoppingListEntry: Shopping list entry 77> with item.actionType=<ActionType.CREATED: 1>
Thread-1 (worker) DEBUG 2024-07-10 11:15:22,826 recipes.connector.homeassistant.test adding item='4'

@mikhail5555 mikhail5555 force-pushed the enable-global-logging-and-more-connector-logging branch from c49b8b4 to edf0694 Compare July 10, 2024 08:54
@mikhail5555 mikhail5555 force-pushed the enable-global-logging-and-more-connector-logging branch from a589f22 to f614413 Compare July 10, 2024 09:17
@vabene1111
Copy link
Collaborator

ok thank you, will get this merged for a intermediate release. Do you want to add some docs for the log level setting? I should probably use the logging framework for all kinds of debug/logging stuff anyway.

@mikhail5555
Copy link
Contributor Author

ok thank you, will get this merged for a intermediate release. Do you want to add some docs for the log level setting? I should probably use the logging framework for all kinds of debug/logging stuff anyway.

If you want, also, do you want me to keep DJANGO_LOG_LEVEL or just change it to LOG_LEVEL which might be a bit more common?

@vabene1111
Copy link
Collaborator

I think LOG_LEVEL makes the most sense.

@mikhail5555 mikhail5555 force-pushed the enable-global-logging-and-more-connector-logging branch from fa23f1e to 1b529bb Compare July 13, 2024 20:41
@mikhail5555
Copy link
Contributor Author

I think LOG_LEVEL makes the most sense.

Let me know when this can get merged so i can debug the issue!

@vabene1111
Copy link
Collaborator

sorry for the long wait, got it merged into develop. If you want to debug with people they can switch from master to develop, there are currently no breaking changes or migrations or anything planned, they are safe to downgrade afterwards.
Maybe this way we can get the fix into the same release :)

thanks for trying to fix this.

@vabene1111 vabene1111 merged commit b19b51c into TandoorRecipes:develop Aug 1, 2024
4 checks passed
@mikhail5555 mikhail5555 deleted the enable-global-logging-and-more-connector-logging branch August 2, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants