Allow PWA Manifest to work behind CF Access / certain proxy configs #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with that request
|
thank you very much for the well documented and reasoned PR. I will need to look at the sources you linked to verifiy this for myself just for security but should not be a problem, will get this merged with the next release if i dont have any further questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am running this app behind Cloudflare Access. Cloudflare Access (and potentially other proxies) ensure that there is a specific authorization cookie on each request going through the proxy. Requests without this cookie get redirected to the login page, or blocked.
It appears that from spec when using a
linktag specifically withrel="manifest"the corscrossoriginattribute is set to anonymous/omit and cookies are stripped from the request by the browser. This is documented here: w3c/manifest#535 with links to several other apps that have implemented similar solutions.This change allows the browser to pass cookies with the request and properly retrieve the manifest.json file, which allows the PWA to be installed as expected.