Merge pull request #8 from Tandashi/fix/#6/RemoveDepricatedCode

Remove old code that was kept to support older versions < 1.7.0

src/model/role.ts

@@ -2,9 +2,5 @@ export enum Role {
     HOST = 'host',
     SUB_HOST = 'sub-host',
     MODERATOR = 'moderator',
-    /**
-     * @deprecated in favor of {@link SUB_HOST} & {@link MODERATOR} permissions.
-     */
-    PROMOTED = 'promoted',
     MEMBER = 'member'
 }

src/model/room.ts

@@ -175,16 +175,6 @@ export class Room {
         return this.getClient(socket).role === Role.MODERATOR;
     }
 
-    /**
-     * Check if the given socket is PROMOTED.
-     *
-     * @deprecated in favor of {@link SUB_HOST} & {@link MODERATOR} permissions.
-     * @param socket The socket to check
-     */
-    public isPromoted(socket: SocketIO.Socket): boolean {
-        return this.getClient(socket).role === Role.PROMOTED;
-    }
-
     /**
      * Update the rooms video state.
      *

src/server.ts

@@ -41,7 +41,7 @@ io.of(/.*/).on('connection', (socket: SocketIO.Socket) => {
             const isHost = room.isHost(socket);
             const isSubHost = room.isSubHost(socket);
             // check for PROMOTED role to stay backwards compatible as MODERATOR and PROMOTED have the same permissions
-            const isModerator = room.isModerator(socket) || room.isPromoted(socket);
+            const isModerator = room.isModerator(socket);
 
             // Check roles of the sender
             // MEMBER - may send reactions
@@ -60,14 +60,6 @@ io.of(/.*/).on('connection', (socket: SocketIO.Socket) => {
                     case Message.SET_ROLE_SUB_HOST:
                         room.changeRoleByClient(room.getClientBySocketId(cmdData), Role.SUB_HOST);
                         return;
-                    // deprecated - backwards compatibility
-                    case Message.PROMOTE:
-                        room.changeRoleByClient(room.getClientBySocketId(cmdData), Role.PROMOTED);
-                        return;
-                    // deprecated - backwards compatibility
-                    case Message.UNPROMOTE:
-                        room.changeRoleByClient(room.getClientBySocketId(cmdData), Role.MEMBER);
-                        return;
                 }
             }