-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update scrollToIndex center-alignment #864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christriants
force-pushed
the
issue-559
branch
from
October 28, 2024 23:22
581ccf6
to
915c8c7
Compare
christriants
force-pushed
the
issue-559
branch
from
October 28, 2024 23:28
915c8c7
to
9ac99ff
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bd21dd9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
piecyk
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the assumption that the current-behavior is not intended, I opened this PR to correct the
align: center
behavior ofscrollToIndex
to align the scroll item's center, not its top, with the center of the list.Video of issue:
https://github.com/user-attachments/assets/7b2445d7-e08e-4eee-aa97-3e454409214c
Video of fix:
https://github.com/user-attachments/assets/607a619e-fc24-4fb4-8c9a-18ec35c917af