Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve npm download count animation #329

Merged

Conversation

erquhart
Copy link
Contributor

@erquhart erquhart commented Dec 31, 2024

NumberFlow can't continuously scroll across number intervals higher than 40 or so, from their docs. In experimenting I found it a good bit lower. Depending on the day (as forecast rate changes daily), the counter will scroll somewhat bizarrely:

The oss stats component now calculates the time interval to ensure value updates stay below the threshold.

Update: now includes fix for failure on npm package not found.

Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit 2b12312
🔍 Latest deploy log https://app.netlify.com/sites/tanstack/deploys/67912ae2d6274d0008f433f6
😎 Deploy Preview https://deploy-preview-329--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 39 (🔴 down 22 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@erquhart erquhart force-pushed the improve-download-count-animation branch from 6228002 to 322cd8b Compare January 7, 2025 02:04
@erquhart erquhart force-pushed the improve-download-count-animation branch from 2b56d71 to 2b12312 Compare January 22, 2025 17:29
@tannerlinsley tannerlinsley merged commit 09b5001 into TanStack:main Jan 22, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants