fix: prevent toLowerCase() is not a function filterFn error(#4776)

TanStack · Mar 26, 2023 · 781beb7 · 781beb7
1 parent b14b7af
commit 781beb7
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/packages/table-core/src/filterFns.ts b/packages/table-core/src/filterFns.ts
@@ -6,7 +6,13 @@ const includesString: FilterFn<any> = (
   filterValue: string
 ) => {
   const search = filterValue.toLowerCase()
-  return Boolean(row.getValue<string>(columnId)?.toLowerCase().includes(search))
+  return Boolean(
+    row
+      .getValue<string | null>(columnId)
+      ?.toString()
+      ?.toLowerCase()
+      .includes(search)
+  )
 }
 
 includesString.autoRemove = (val: any) => testFalsey(val)
@@ -16,7 +22,9 @@ const includesStringSensitive: FilterFn<any> = (
   columnId: string,
   filterValue: string
 ) => {
-  return Boolean(row.getValue<string>(columnId)?.includes(filterValue))
+  return Boolean(
+    row.getValue<string | null>(columnId)?.toString()?.includes(filterValue)
+  )
 }
 
 includesStringSensitive.autoRemove = (val: any) => testFalsey(val)
@@ -27,7 +35,8 @@ const equalsString: FilterFn<any> = (
   filterValue: string
 ) => {
   return (
-    row.getValue<string>(columnId)?.toLowerCase() === filterValue.toLowerCase()
+    row.getValue<string | null>(columnId)?.toString()?.toLowerCase() ===
+    filterValue?.toLowerCase()
   )
 }