Skip to content

fix(prefetchQuery): Throw error when throwOnError is set #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2020
Merged

fix(prefetchQuery): Throw error when throwOnError is set #310

merged 2 commits into from
Apr 3, 2020

Conversation

kamranayub
Copy link
Contributor

@kamranayub kamranayub commented Apr 3, 2020 •
edited
Loading

Fixes #309

The previous test added for #167 still passes, so I would assume this is safe.

Changes

@kamranayub kamranayub marked this pull request as ready for review April 3, 2020 19:22
@tannerlinsley
Copy link
Collaborator

Nice Catch!

@tannerlinsley tannerlinsley merged commit df536e8 into TanStack:master Apr 3, 2020
@kamranayub kamranayub deleted the bug/prefetch-throwonerror branch April 3, 2020 20:18
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e6b05d7.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-07 02:56:21 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: prefetchQuery does not throw error when throwOnError is true
2 participants
@kamranayub @tannerlinsley