react really wants no side-effects during render

TanStack · May 24, 2024 · e728bfe · e728bfe
1 parent 7016b42
commit e728bfe
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/react-query/src/__tests__/useMutation.test.tsx b/packages/react-query/src/__tests__/useMutation.test.tsx
@@ -718,15 +718,14 @@ describe('useMutation', () => {
       .mockImplementation(() => undefined)
     let boundary = false
     function Page() {
-      const { mutate, error } = useMutation<string, Error>({
+      const { mutate, error } = useMutation<string>({
         mutationFn: () => {
           const err = new Error('mock error')
           err.stack = ''
           return Promise.reject(err)
         },
         throwOnError: () => {
-          boundary = !boundary
-          return !boundary
+          return boundary
         },
       })
 
@@ -758,6 +757,7 @@ describe('useMutation', () => {
     })
 
     // second error goes to boundary
+    boundary = true
     fireEvent.click(getByText('mutate'))
     await waitFor(() => {
       expect(queryByText('error boundary')).not.toBeNull()