chore: upload code-coverage during build process

by decoupling test running from publishing; we now always run the tests when pushed to main
this should help us get a correct baseline

.github/workflows/ci.yml

@@ -26,8 +26,12 @@ jobs:
           node-version: 16.14.2
           registry-url: https://registry.npmjs.org/
           cache: 'pnpm'
-      - run: |
-          pnpm --filter "./packages/**" --filter query --prefer-offline install
+      - name: Install dependencies
+        run: pnpm --filter "./packages/**" --filter query --prefer-offline install
+      - name: Run Tests
+        run: pnpm run test:ci
+      - name: Publish
+        run: |
           git config --global user.name 'Tanner Linsley'
           git config --global user.email 'tannerlinsley@users.noreply.github.com'
           npm config set '//registry.npmjs.org/:_authToken' "${NPM_TOKEN}"
@@ -38,3 +42,5 @@ jobs:
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           TAG: ${{ inputs.tag }}
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v2

package.json

@@ -6,13 +6,12 @@
     "preinstall": "node -e \"if(process.env.CI == 'true') {console.log('Skipping preinstall...'); process.exit(1)}\" || npx -y only-allow pnpm",
     "install:csb": "pnpm install --frozen-lockfile",
     "test": "pnpm run test:ci",
-    "test:ci": "pnpm run test:format && pnpm run test:eslint && pnpm run test:lib:publish && pnpm run test:types",
+    "test:ci": "pnpm run test:format && pnpm run test:eslint && pnpm run test:lib && pnpm run test:types",
     "test:react:17": "pnpm --filter \"./packages/react-*\" run test:lib",
     "test:eslint": "pnpm --filter \"./packages/**\" run test:eslint",
     "test:format": "pnpm run prettier --check",
     "test:lib": "pnpm --filter \"./packages/**\" run test:lib",
     "test:lib:dev": "pnpm --filter \"./packages/**\" run test:lib:dev",
-    "test:lib:publish": "pnpm --filter \"./packages/**\" run test:lib:publish",
     "test:size": "pnpm run build && bundlewatch",
     "test:types": "pnpm --filter \"./packages/**\" run test:types",
     "build": "rollup --config rollup.config.js && pnpm --filter \"./packages/**\" run build && pnpm run build:types",

packages/eslint-plugin-query/package.json

@@ -18,7 +18,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build": "tsup --minify"
   },
   "files": [

packages/query-async-storage-persister/package.json

@@ -33,7 +33,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build:types": "tsc --build"
   },
   "dependencies": {

packages/query-core/package.json

@@ -33,7 +33,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build:types": "tsc --build"
   }
 }

packages/query-persist-client-core/package.json

@@ -33,7 +33,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build:types": "tsc --build"
   },
   "devDependencies": {

packages/query-sync-storage-persister/package.json

@@ -33,7 +33,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build:types": "tsc --build"
   },
   "dependencies": {

packages/react-query-devtools/package.json

@@ -43,7 +43,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build:types": "tsc --build && cp build/lib/index.d.ts build/lib/index.prod.d.ts"
   },
   "devDependencies": {

packages/react-query-persist-client/package.json

@@ -33,7 +33,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build:types": "tsc --build"
   },
   "devDependencies": {

packages/react-query/package.json

@@ -30,7 +30,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build:types": "tsc --build"
   },
   "files": [

packages/solid-query/package.json

@@ -32,8 +32,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
-    "build:types": "tsc --build"
   },
   "files": [
     "build/lib/*",

packages/svelte-query/package.json

@@ -19,7 +19,6 @@
     "test:eslint": "eslint --ext .svelte,.ts ./src",
     "test:lib": "vitest run --coverage true",
     "test:lib:dev": "vitest watch",
-    "test:lib:publish": "vitest run --coverage false",
     "build": "svelte-package && rimraf ./build/lib/package.json"
   },
   "devDependencies": {

packages/vue-query/package.json

@@ -32,7 +32,6 @@
     "test:types": "tsc",
     "test:lib": "jest --config ./jest.config.ts",
     "test:lib:dev": "pnpm run test:lib --watch",
-    "test:lib:publish": "pnpm run test:lib --collectCoverage false",
     "build:types": "tsc --build"
   },
   "files": [

scripts/publish.ts

@@ -368,10 +368,6 @@ async function run() {
     return
   }
 
-  console.info('Testing packages...')
-  execSync(`pnpm run test:ci`, { encoding: 'utf8', stdio: 'inherit' })
-  console.info('')
-
   console.info('Building packages...')
   execSync(`pnpm run build`, { encoding: 'utf8', stdio: 'inherit' })
   console.info('')