-
-
Notifications
You must be signed in to change notification settings - Fork 527
fix(form-core): respect dontValidate option in formApi array modifiers #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
check the `dontValidate` option in array modifiers before applying validation fix TanStack#1764
🦋 Changeset detectedLatest commit: be6add4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I couldn't find a single test that checks the |
View your CI Pipeline Execution ↗ for commit be6add4
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Not sure why codecov is not tracking this, but either way, unit tests for meta options would be great!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
+ Coverage 90.35% 90.53% +0.18%
==========================================
Files 38 38
Lines 1752 1797 +45
Branches 444 464 +20
==========================================
+ Hits 1583 1627 +44
- Misses 149 150 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you, I'll try to create a separate PR for adding tests |
I'll merge later today. Thanks for the PR! |
fix #1764
🎯 Changes
check the
dontValidate
option in array modifiers before applying validation✅ Checklist
pnpm test:pr
.🚀 Release Impact