Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm when trying to navigate between tabs without saving #900

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Confirm when trying to navigate between tabs without saving #900

merged 2 commits into from
Dec 28, 2023

Conversation

mmoila
Copy link
Contributor

@mmoila mmoila commented Dec 21, 2023 •
edited
Loading

  • Updated react-router & react-router-dom to gain access to useBlocker
  • NavigationBlocker component is used to confirm navigation when there is unsaved work

@github-actions github-actions bot added the feature New feature label Dec 21, 2023
@mmoila mmoila marked this pull request as ready for review December 21, 2023 11:44
@mmoila mmoila requested a review from tkataja December 21, 2023 11:44
tkataja
tkataja approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@tkataja tkataja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mmoila mmoila merged commit 5f0f185 into main Dec 28, 2023
8 checks passed
@mmoila mmoila deleted the feature/notification-on-object-tab-change branch December 28, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkataja tkataja tkataja approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmoila @tkataja