Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ext users from user selectors #859

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Remove ext users from user selectors #859

merged 2 commits into from
Nov 24, 2023

Conversation

mmoila
Copy link
Contributor

@mmoila mmoila commented Nov 24, 2023

  • Added new getAllNonExtUsers function to get all users without @ext.tampere.fi email for selectors
  • Other option would be to modify the getAllUsers function to always disregard @ext.tampere.fi users
  • Also changed one <h> tag to <h1>to make it semantically correct

@mmoila mmoila requested a review from tkataja November 24, 2023 13:16
@github-actions github-actions bot added the fix Bugfix label Nov 24, 2023
tkataja
tkataja approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@tkataja tkataja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps drop the extra % from the LIKE query before merge

@mmoila mmoila merged commit f5dc265 into main Nov 24, 2023
8 checks passed
@mmoila mmoila deleted the fix/remove-ubigu-users-from-listings branch November 24, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkataja tkataja tkataja approved these changes

Assignees
No one assigned
Labels
fix Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmoila @tkataja