Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove old checkbox #896

Merged
merged 2 commits into from
Jul 10, 2023
Merged

refactor: remove old checkbox #896

merged 2 commits into from
Jul 10, 2023

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Jun 29, 2023 •
edited
Loading

Tasks:

  • Removed components/Field/Checkbox
  • Waiting on Batch Import P.JS #865 to be merged before removing components/Checkbox (involves tweaking the new checkbox which is also tweaked in 865)

@0xKheops 0xKheops mentioned this pull request Jul 9, 2023
Merged
@0xKheops 0xKheops marked this pull request as ready for review July 10, 2023 00:46
@0xKheops 0xKheops enabled auto-merge (squash) July 10, 2023 00:47
@0xKheops 0xKheops requested a review from chidg July 10, 2023 00:47
chidg
chidg approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKheops 0xKheops merged commit accd198 into dev Jul 10, 2023
4 checks passed
@0xKheops 0xKheops deleted the feat/remove-old-checkbox branch July 10, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg chidg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite Toggle and Checkbox components
2 participants
@0xKheops @chidg