Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eip 712 validation #894

Merged
merged 7 commits into from
Jul 3, 2023
Merged

fix: eip 712 validation #894

merged 7 commits into from
Jul 3, 2023

Conversation

0xKheops
Copy link
Contributor

  • Fixes Chaintroopers #1015 #892
  • Fixed styles for sign forms's buttons along the way, as adding the warning showcased a padding problem above buttons

@0xKheops 0xKheops enabled auto-merge (squash) June 29, 2023 02:31
@0xKheops 0xKheops requested a review from chidg June 29, 2023 02:31
@0xKheops 0xKheops marked this pull request as draft June 29, 2023 02:33
auto-merge was automatically disabled June 29, 2023 02:33

Pull request was converted to draft

@0xKheops 0xKheops removed the request for review from chidg June 29, 2023 02:34
@0xKheops 0xKheops marked this pull request as ready for review June 29, 2023 02:37
@0xKheops 0xKheops requested a review from chidg June 29, 2023 02:37
@0xKheops 0xKheops enabled auto-merge (squash) June 29, 2023 02:38
chidg
chidg previously approved these changes Jul 3, 2023
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKheops 0xKheops merged commit 0bfd7da into dev Jul 3, 2023
4 checks passed
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKheops 0xKheops deleted the fix/eip-712-validation branch July 3, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chaintroopers #1015
2 participants