Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate simple localize #834

Merged
merged 15 commits into from
Jul 10, 2023
Merged

Integrate simple localize #834

merged 15 commits into from
Jul 10, 2023

Conversation

chidg
Copy link
Contributor

@chidg chidg commented Jun 12, 2023

How it works:

  • locale files are no longer stored in the repo
  • when a branch is pushed, a github action extracts the english keys and uploads to SL
  • translations are added by our translators on SL
  • when a build is made, the SimpleLocalizeDownloadPlugin in webpack pulls the available languages and applicable translations for the labels from SL and includes the locale files in the build

@chidg chidg self-assigned this Jul 3, 2023
@chidg chidg changed the title [WIP] Integrate simple localize Integrate simple localize Jul 5, 2023
@chidg chidg requested review from alecdwm and 0xKheops July 5, 2023 08:22
Copy link
Contributor

@0xKheops 0xKheops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chidg chidg merged commit 6a30810 into dev Jul 10, 2023
4 checks passed
@chidg chidg deleted the chore/integrate-locize branch July 10, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants