Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Notification system #56

Merged
merged 19 commits into from
Apr 25, 2022
Merged

Notification system #56

merged 19 commits into from
Apr 25, 2022

Conversation

Taliayaya
Copy link
Owner

@Taliayaya Taliayaya commented Apr 24, 2022

Description

Sending a message from a different channel and user now send a notification to the users. Channels change color whether a new message is sent or not, and if this new message isn't seen yet. Clicking on a notification redirects toward Apando at the current message position, in the right server.

However, these notifications are not from a server push. This mean it will only work if the website is open in a tab. Having this tab in the background is enough. To have a server push, we need to set up a Service Worker. Making a Service Worker isn't a death or life matter for now.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

No tests where made...yet. WE HAVE TO AAAAAAAAAAAAAAAAA

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Taliayaya Taliayaya added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 24, 2022
@Taliayaya Taliayaya self-assigned this Apr 24, 2022
@Taliayaya Taliayaya merged commit d34e791 into main Apr 25, 2022
@Taliayaya Taliayaya mentioned this pull request Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant